FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

doc: fix esm markdown file by popmoore · Pull Request #53170 · nodejs/node · GitHub

/ node Public

doc: fix esm markdown file - #53170

Merged
aduh95 merged 1 commit into
nodejs:mainfrom
popmoore:main
May 27, 2024
ConversationCommits (1)ChecksFiles changed
Merged

doc: fix esm markdown file#53170
aduh95 merged 1 commit into
nodejs:mainfrom
popmoore:main

Conversation

popmoore commented May 26, 2024

Copy link
Copy Markdown
Contributor
  • Fix esm doc format

nodejs-github-bot commented May 26, 2024

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/loaders

nodejs-github-bot added doc Issues and PRs related to the documentations. esm Issues and PRs related to the ECMAScript Modules implementation. labels May 26, 2024

deokjinkim commented May 27, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

@popmoore Thank you for your contribution. Please replace docs with doc in commit title.
Below is guidelines for commit message.
https://github.com/nodejs/node/blob/main/doc/contributing/pull-requests.md#commit-message-guidelines

popmoore changed the title docs: fix esm markdown file doc: fix esm markdown file May 27, 2024

popmoore commented May 27, 2024

Copy link
Copy Markdown
Contributor Author

@popmoore Thank you for your contribution. Please replace docs with doc in commit title. Below is guidelines for commit message. https://github.com/nodejs/node/blob/main/doc/contributing/pull-requests.md#commit-message-guidelines

Hi @deokjinkim I changed the commit title, can you approve the CI workflows

deokjinkim added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label May 27, 2024
aduh95 added the fast-track PRs that do not need to wait for 48 hours to land. label May 27, 2024

github-actions Bot commented May 27, 2024

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @aduh95. Please 👍 to approve.

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view
aduh95 merged commit 72a4470 into nodejs:main May 27, 2024

aduh95 commented May 27, 2024

Copy link
Copy Markdown
Contributor

Landed in 72a4470

targos pushed a commit that referenced this pull request Jun 1, 2024
doc: fix format in esm.md
1702d26 
PR-URL: #53170
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Deokjin Kim <deokjin81.kim@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
RafaelGSS mentioned this pull request Jun 7, 2024
Merged
eliphazbouye pushed a commit to eliphazbouye/node that referenced this pull request Jun 20, 2024
doc: fix format in esm.md
51ce790 
PR-URL: nodejs#53170
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Deokjin Kim <deokjin81.kim@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
marco-ippolito pushed a commit that referenced this pull request Jul 19, 2024
doc: fix format in esm.md
3ac775b 
PR-URL: #53170
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Deokjin Kim <deokjin81.kim@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
marco-ippolito mentioned this pull request Jul 19, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

GeoffreyBooth GeoffreyBooth approved these changes
lpinca lpinca approved these changes
deokjinkim deokjinkim approved these changes
aduh95 aduh95 approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. doc Issues and PRs related to the documentations. esm Issues and PRs related to the ECMAScript Modules implementation. fast-track PRs that do not need to wait for 48 hours to land.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL