doc: remove cases for keys not containing "*" in PATTERN_KEY_COMPARE - #53215
Merged
nodejs-github-bot merged 1 commit intoJun 5, 2024
Merged
doc: remove cases for keys not containing "*" in PATTERN_KEY_COMPARE#53215nodejs-github-bot merged 1 commit into
nodejs-github-bot merged 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
|
Review requested:
|
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
Had to force push to fix the commit message. |
Sorry, something went wrong.
aduh95
reviewed
May 30, 2024
Comment thread
doc/api/esm.md
aduh95
approved these changes
May 30, 2024
guybedford
approved these changes
Jun 1, 2024
Copy link
Copy Markdown
Contributor
Author
|
Is there anything else needed from my end to get this merged? |
Sorry, something went wrong.
Merged
soophoo
pushed a commit
to soophoo/node
that referenced
this pull request
Jun 20, 2024
PR-URL: nodejs#53215 Fixes: nodejs#53206 Refs: nodejs#40121 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Guy Bedford <guybedford@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes cases in the reference documentation for PATTERN_KEY_COMPARE where a key does not contain a "*". Given the reference of PACKAGE_IMPORTS_EXPORTS_RESOLVE (the only place where PATTERN_KEY_COMPARE is called), keys that are passed to PATTERN_KEY_COMPARE always contain a single "*".
These cases were likely there for legacy reasons, when keys could end with "/" instead of using wildcards, but this documentation wasn't updated when support for this was removed.
Refs: #40121
Fixes: #53206