build: find version of Clang installed on Windows - #53228
Merged
nodejs-github-bot merged 1 commit intoJun 11, 2024
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
This comment was marked as outdated.
targos
approved these changes
May 31, 2024
targos
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
RSLGTM
Sorry, something went wrong.
This comment was marked as outdated.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Commit Queue failed- Loading data for nodejs/node/pull/53228 ✔ Done loading data for nodejs/node/pull/53228 ----------------------------------- PR info ------------------------------------ Title build: find version of Clang installed on Windows (#53228) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch StefanStojanovic:huseyin-12229-implement-clang-version-detection -> nodejs:main Labels doc, windows, install, build, tools, needs-ci Commits 1 - build: find version of Clang installed on Windows Committers 1 - StefanStojanovic PR-URL: https://github.com/nodejs/node/pull/53228 Refs: https://github.com/nodejs/node/issues/52809 Reviewed-By: Michaël Zasso ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/53228 Refs: https://github.com/nodejs/node/issues/52809 Reviewed-By: Michaël Zasso -------------------------------------------------------------------------------- ℹ This PR was created on Fri, 31 May 2024 10:45:42 GMT ✔ Approvals: 1 ✔ - Michaël Zasso (@targos) (TSC): https://github.com/nodejs/node/pull/53228#pullrequestreview-2090704833 ✘ This PR needs to wait 97 more hours to land (or 0 hours if there is one more approval) ✔ Last GitHub CI successful ℹ Last Full PR CI on 2024-06-03T08:23:03Z: https://ci.nodejs.org/job/node-test-pull-request/59632/ - Querying data for job/node-test-pull-request/59632/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/9347653198 |
Sorry, something went wrong.
soophoo
pushed a commit
to soophoo/node
that referenced
this pull request
Jun 20, 2024
PR-URL: nodejs#53228 Refs: nodejs#52809 Reviewed-By: Michaël Zasso <targos@protonmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
1 more reviewer3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed, we want to be able to fetch the version of the installed ClangCL dynamically, so we do not keep it hardcoded. This change takes an initial step in that direction. For now, we require Clang to be installed from a Visual Studio installation as an individual component. Later, once we finish adding support for Clang on Windows, we should aim to improve this by allowing users to install Clang themselves and use it Node.js.
This approach uses the vswhere_usability_wrapper.cmd to ensure that required components are installed when compiling with Clang.
Refs: #52809