FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

tools: add stream label on PR when related files being changed in lib by jakecastelli · Pull Request #53269 · nodejs/node · GitHub

/ node Public

tools: add stream label on PR when related files being changed in lib - #53269

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
jakecastelli:fix-stream-label-on-pr
Jun 7, 2024
ConversationCommits (1)ChecksFiles changed
Merged

tools: add stream label on PR when related files being changed in lib#53269
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
jakecastelli:fix-stream-label-on-pr

Conversation

jakecastelli commented Jun 3, 2024

Copy link
Copy Markdown
Member

I have noticed that changes related to stream in the lib folder do not automatically add stream label on the PR, and requires collaborator or triager to manually do so. I am not sure if there is a reason that I am not aware of, but this PR should potentially fix it.

Files covered by the regex (totally 27 files):

➜  $ find lib -type f | grep '^lib\/\(_stream.*\|internal/streams/.*\|stream\.js\|stream/.*\)$'        
lib/stream.js
lib/stream/consumers.js
lib/stream/promises.js
lib/stream/web.js
lib/internal/streams/add-abort-signal.js
lib/internal/streams/compose.js
lib/internal/streams/duplexify.js
lib/internal/streams/destroy.js
lib/internal/streams/legacy.js
lib/internal/streams/passthrough.js
lib/internal/streams/operators.js
lib/internal/streams/readable.js
lib/internal/streams/from.js
lib/internal/streams/writable.js
lib/internal/streams/state.js
lib/internal/streams/end-of-stream.js
lib/internal/streams/utils.js
lib/internal/streams/transform.js
lib/internal/streams/lazy_transform.js
lib/internal/streams/duplex.js
lib/internal/streams/pipeline.js
lib/_stream_wrap.js
lib/_stream_passthrough.js
lib/_stream_transform.js
lib/_stream_duplex.js
lib/_stream_readable.js
lib/_stream_writable.js

nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Jun 3, 2024

richardlau commented Jun 3, 2024

Copy link
Copy Markdown
Member

cc @nodejs/streams

benjamingr commented Jun 3, 2024

Copy link
Copy Markdown
Member

sure, wanna open a PR?

jakecastelli commented Jun 3, 2024

Copy link
Copy Markdown
Member Author

Hi @benjamingr I tried to fix it in this PR (maybe you thought it was an issue ;p)

targos approved these changes Jun 3, 2024
View reviewed changes

targos left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM.

Schematic version of the regex: https://regexper.com/#%2F%5Elib%5C%2F%28_stream.*%7Cinternal%5C%2Fstreams%5C%2F.*%7Cstream%5C.js%7Cstream%5C%2F.*%29%24%2F

benjamingr approved these changes Jun 3, 2024
View reviewed changes

benjamingr left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Yes, absolutely!

mcollina approved these changes Jun 4, 2024
View reviewed changes

mcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

lgtm

lpinca added the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 7, 2024
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 7, 2024
nodejs-github-bot merged commit 5c3ecbe into nodejs:main Jun 7, 2024

nodejs-github-bot commented Jun 7, 2024

Copy link
Copy Markdown
Collaborator

Landed in 5c3ecbe

targos pushed a commit that referenced this pull request Jun 20, 2024
tools: add stream label on PR when related files being changed in lib
855eb25 
PR-URL: #53269
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
eliphazbouye pushed a commit to eliphazbouye/node that referenced this pull request Jun 20, 2024
tools: add stream label on PR when related files being changed in lib
fead293 
PR-URL: nodejs#53269
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos mentioned this pull request Jun 25, 2024
Merged
Karliz24 mentioned this pull request Jul 9, 2024
Open
marco-ippolito pushed a commit that referenced this pull request Jul 19, 2024
tools: add stream label on PR when related files being changed in lib
e9b7a52 
PR-URL: #53269
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
marco-ippolito mentioned this pull request Jul 19, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

mcollina mcollina approved these changes
benjamingr benjamingr approved these changes
lpinca lpinca approved these changes
+1 more reviewer
targos targos approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

meta Issues and PRs related to the general management of the project.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

Back | FazBrowse Home | New Git URL