FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

tools,doc: parse types in braces everywhere by estliberitas · Pull Request #5329 · nodejs/node · GitHub

/ node Public

tools,doc: parse types in braces everywhere - #5329

Closed
estliberitas wants to merge 1 commit into
nodejs:masterfrom
estliberitas:tool-doc-add-types
ConversationCommits (1)ChecksFiles changed
Closed

tools,doc: parse types in braces everywhere#5329
estliberitas wants to merge 1 commit into
nodejs:masterfrom
estliberitas:tool-doc-add-types

Conversation

estliberitas commented Feb 19, 2016

Copy link
Copy Markdown
Contributor

Also add EvalError, RangeError, ReferenceError, SyntaxError,
TypeError, URIError to list of global types. Fix errors.markdown
copy accordingly.

Fixes #5325.

estliberitas reviewed Feb 19, 2016
View reviewed changes
Comment thread tools/doc/html.js Outdated

estliberitas Feb 19, 2016

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

This will have side effects, only if we will write something like....

Some missing {type} or { code: 'without backquote' }

mscdex added doc Issues and PRs related to the documentations. tools Issues and PRs related to the tools directory. labels Feb 19, 2016
jasnell reviewed Feb 19, 2016
View reviewed changes
Comment thread doc/api/errors.markdown Outdated

jasnell Feb 19, 2016

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Why remove these links?

estliberitas Feb 20, 2016

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Forgot to mention #5325 in a commit. This is why actually I created PR. #5325 in turn was caused by #5322

stevemao Apr 18, 2016

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Sorry @estliberitas , since #5641 fixes the broken links, do we still need to remove them?

jasnell commented Feb 20, 2016

Copy link
Copy Markdown
Member

+1... ok, LGTM!

silverwind commented Feb 27, 2016

Copy link
Copy Markdown
Contributor

This needs a rebase now.

estliberitas commented Feb 27, 2016

Copy link
Copy Markdown
Contributor Author

@silverwind Done

estliberitas mentioned this pull request Mar 10, 2016
Closed

jasnell commented Apr 2, 2016

Copy link
Copy Markdown
Member

Oy.. looks like it needs another rebase. If you can get that I'll look at landing next week

estliberitas commented Apr 2, 2016

Copy link
Copy Markdown
Contributor Author

@jasnell I'll fix tmrw

tools,doc: parse types in braces everywhere
220e2d7 
Also add `EvalError`, `RangeError`, `ReferenceError`, `SyntaxError`,
`TypeError`, `URIError` to list of global types. Fix errors.markdown
copy accordingly.

Fixes #5325.

estliberitas commented Apr 4, 2016

Copy link
Copy Markdown
Contributor Author

@jasnell done

jasnell commented Apr 4, 2016

Copy link
Copy Markdown
Member

@nodejs/documentation ... another quick review please? :-)

eljefedelrodeodeljefe commented Apr 4, 2016

Copy link
Copy Markdown
Contributor

LGTM

eljefedelrodeodeljefe commented Apr 18, 2016

Copy link
Copy Markdown
Contributor

ping @jasnell

jasnell commented Apr 18, 2016

Copy link
Copy Markdown
Member

LGTM

jasnell pushed a commit that referenced this pull request Apr 18, 2016
tools,doc: parse types in braces everywhere
eafd31a 
Also add `EvalError`, `RangeError`, `ReferenceError`, `SyntaxError`,
`TypeError`, `URIError` to list of global types. Fix errors.markdown
copy accordingly.

Fixes: #5325.
PR-URL: #5329
Reviewed-By: James M Snell <jasnell@gmail.com>

jasnell commented Apr 18, 2016

Copy link
Copy Markdown
Member

Landed in eafd31a

jasnell closed this Apr 18, 2016
MylesBorins pushed a commit that referenced this pull request Apr 19, 2016
tools,doc: parse types in braces everywhere
3a6d776 
Also add `EvalError`, `RangeError`, `ReferenceError`, `SyntaxError`,
`TypeError`, `URIError` to list of global types. Fix errors.markdown
copy accordingly.

Fixes: #5325.
PR-URL: #5329
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Apr 20, 2016
tools,doc: parse types in braces everywhere
07484a9 
Also add `EvalError`, `RangeError`, `ReferenceError`, `SyntaxError`,
`TypeError`, `URIError` to list of global types. Fix errors.markdown
copy accordingly.

Fixes: #5325.
PR-URL: #5329
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Apr 20, 2016
tools,doc: parse types in braces everywhere
2567f2d 
Also add `EvalError`, `RangeError`, `ReferenceError`, `SyntaxError`,
`TypeError`, `URIError` to list of global types. Fix errors.markdown
copy accordingly.

Fixes: #5325.
PR-URL: #5329
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins mentioned this pull request Apr 20, 2016
Closed
MylesBorins pushed a commit that referenced this pull request Apr 20, 2016
tools,doc: parse types in braces everywhere
d516412 
Also add `EvalError`, `RangeError`, `ReferenceError`, `SyntaxError`,
`TypeError`, `URIError` to list of global types. Fix errors.markdown
copy accordingly.

Fixes: #5325.
PR-URL: #5329
Reviewed-By: James M Snell <jasnell@gmail.com>
This was referenced Apr 21, 2016
Closed
Closed
MylesBorins pushed a commit that referenced this pull request Apr 21, 2016
tools,doc: parse types in braces everywhere
0658632 
Also add `EvalError`, `RangeError`, `ReferenceError`, `SyntaxError`,
`TypeError`, `URIError` to list of global types. Fix errors.markdown
copy accordingly.

Fixes: #5325.
PR-URL: #5329
Reviewed-By: James M Snell <jasnell@gmail.com>
joelostrowski pushed a commit to joelostrowski/node that referenced this pull request Apr 25, 2016
tools,doc: parse types in braces everywhere
2620716 
Also add `EvalError`, `RangeError`, `ReferenceError`, `SyntaxError`,
`TypeError`, `URIError` to list of global types. Fix errors.markdown
copy accordingly.

Fixes: nodejs#5325.
PR-URL: nodejs#5329
Reviewed-By: James M Snell <jasnell@gmail.com>
jasnell pushed a commit that referenced this pull request Apr 26, 2016
tools,doc: parse types in braces everywhere
df9e6fb 
Also add `EvalError`, `RangeError`, `ReferenceError`, `SyntaxError`,
`TypeError`, `URIError` to list of global types. Fix errors.markdown
copy accordingly.

Fixes: #5325.
PR-URL: #5329
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request May 3, 2016
tools,doc: parse types in braces everywhere
aeea832 
Also add `EvalError`, `RangeError`, `ReferenceError`, `SyntaxError`,
`TypeError`, `URIError` to list of global types. Fix errors.markdown
copy accordingly.

Fixes: #5325.
PR-URL: #5329
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request May 6, 2016
tools,doc: parse types in braces everywhere
ab7f3dd 
Also add `EvalError`, `RangeError`, `ReferenceError`, `SyntaxError`,
`TypeError`, `URIError` to list of global types. Fix errors.markdown
copy accordingly.

Fixes: #5325.
PR-URL: #5329
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request May 18, 2016
tools,doc: parse types in braces everywhere
c893cd3 
Also add `EvalError`, `RangeError`, `ReferenceError`, `SyntaxError`,
`TypeError`, `URIError` to list of global types. Fix errors.markdown
copy accordingly.

Fixes: #5325.
PR-URL: #5329
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins mentioned this pull request May 18, 2016
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

doc Issues and PRs related to the documentations. tools Issues and PRs related to the tools directory.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

Back | FazBrowse Home | New Git URL