doc: refine child_process detach behaviour - #5330
Conversation
Sorry, something went wrong.
There was a problem hiding this comment.
Perhaps: *Note that detaching a process is platform specific.* ... also would be good to list the platform specific differences here.
Sorry, something went wrong.
|
@nodejs/documentation |
Sorry, something went wrong.
|
enhanced upon @jasnell's comment. Note, the reason I wanted to mention the specific behaviour down there again is because copy-pasting the either of the code snippet will likely lead to unwanted behaviour depending on which platform you are. The API isn't really consistent there, which of course is OS'es nature of different process implementations. I also removed " and a you reference. |
Sorry, something went wrong.
There was a problem hiding this comment.
Looking at the new layout of the file, this note seems unnecessary.
Sorry, something went wrong.
|
LGTM with a few comments. |
Sorry, something went wrong.
this adds an example of a long running node process that actually executes node code. Also it mentions the not to harmonic detach behaviours of the different platforms, whereas detaching on unix requires ignoring the child_process' stdio explicitely.
|
@cjihrig addressed your comments. Content-wise I just omitted the SIGHUP discussion generically. |
Sorry, something went wrong.
|
Cool. Thanks. If @jasnell is good with it, we can land this. |
Sorry, something went wrong.
|
LGTM |
Sorry, something went wrong.
this adds an example of a long running node process that actually executes node code. Also it mentions the not to harmonic detach behaviours of the different platforms, whereas detaching on unix requires ignoring the child_process' stdio explicitely. PR-URL: #5330 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
this adds an example of a long running node process that actually executes node code. Also it mentions the not to harmonic detach behaviours of the different platforms, whereas detaching on unix requires ignoring the child_process' stdio explicitely. PR-URL: #5330 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
this adds an example of a long running node process that actually executes node code. Also it mentions the not to harmonic detach behaviours of the different platforms, whereas detaching on unix requires ignoring the child_process' stdio explicitely. PR-URL: #5330 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
This adds an example of a long running node process that actually
executes node code.
Also it mentions the not to harmonic detach behaviours of the
different platforms, which might also invite some core work.
I felt this to be necessary after researching for #5146, whereas the the behaviour of detaching seems highly inconsistent and very untransparent for the user.
/cc @nodejs/documentation