doc: remove first timer badge - #53338
Merged
aduh95 merged 2 commits intoJun 17, 2024
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
|
Review requested:
|
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
Although, if you'd like to keep the badge, I've made an SVG modern version of it. |
Sorry, something went wrong.
lpinca
approved these changes
Jun 5, 2024
UlisesGascon
approved these changes
Jun 6, 2024
mcollina
approved these changes
Jun 6, 2024
mcollina
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
lgtm
Sorry, something went wrong.
panva
approved these changes
Jun 6, 2024
tniessen
approved these changes
Jun 6, 2024
Comment thread
doc/contributing/collaborator-guide.md
Outdated
Co-authored-by: Tobias Nießen <tniessen@tnie.de>
marco-ippolito
approved these changes
Jun 6, 2024
Copy link
Copy Markdown
Collaborator
Commit Queue failed- Loading data for nodejs/node/pull/53338 ✔ Done loading data for nodejs/node/pull/53338 ----------------------------------- PR info ------------------------------------ Title doc: remove first timer badge (#53338) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch RedYetiDev:remove- -> nodejs:main Labels doc Commits 2 - doc: remove first timer badge - Update doc/contributing/collaborator-guide.md Committers 2 - RedYetiDev <38299977+RedYetiDev@users.noreply.github.com> - GitHub PR-URL: https://github.com/nodejs/node/pull/53338 Reviewed-By: Luigi Pinca Reviewed-By: Ulises Gascón Reviewed-By: Matteo Collina Reviewed-By: Filip Skokan Reviewed-By: Tobias Nießen Reviewed-By: Marco Ippolito ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/53338 Reviewed-By: Luigi Pinca Reviewed-By: Ulises Gascón Reviewed-By: Matteo Collina Reviewed-By: Filip Skokan Reviewed-By: Tobias Nießen Reviewed-By: Marco Ippolito -------------------------------------------------------------------------------- ℹ This PR was created on Tue, 04 Jun 2024 16:43:35 GMT ✔ Approvals: 6 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/53338#pullrequestreview-2100112730 ✔ - Ulises Gascón (@UlisesGascon): https://github.com/nodejs/node/pull/53338#pullrequestreview-2101440281 ✔ - Matteo Collina (@mcollina) (TSC): https://github.com/nodejs/node/pull/53338#pullrequestreview-2101528323 ✔ - Filip Skokan (@panva): https://github.com/nodejs/node/pull/53338#pullrequestreview-2101538471 ✔ - Tobias Nießen (@tniessen) (TSC): https://github.com/nodejs/node/pull/53338#pullrequestreview-2101739951 ✔ - Marco Ippolito (@marco-ippolito) (TSC): https://github.com/nodejs/node/pull/53338#pullrequestreview-2102071302 ✘ Last GitHub CI failed ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/9404810010 |
Sorry, something went wrong.
RafaelGSS
approved these changes
Jun 7, 2024
Copy link
Copy Markdown
Collaborator
Commit Queue failed- Loading data for nodejs/node/pull/53338 ✔ Done loading data for nodejs/node/pull/53338 ----------------------------------- PR info ------------------------------------ Title doc: remove first timer badge (#53338) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch RedYetiDev:remove- -> nodejs:main Labels doc, commit-queue-squash Commits 2 - doc: remove first timer badge - Update doc/contributing/collaborator-guide.md Committers 2 - RedYetiDev <38299977+RedYetiDev@users.noreply.github.com> - GitHub PR-URL: https://github.com/nodejs/node/pull/53338 Reviewed-By: Luigi Pinca Reviewed-By: Ulises Gascón Reviewed-By: Matteo Collina Reviewed-By: Filip Skokan Reviewed-By: Tobias Nießen Reviewed-By: Marco Ippolito Reviewed-By: Rafael Gonzaga ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/53338 Reviewed-By: Luigi Pinca Reviewed-By: Ulises Gascón Reviewed-By: Matteo Collina Reviewed-By: Filip Skokan Reviewed-By: Tobias Nießen Reviewed-By: Marco Ippolito Reviewed-By: Rafael Gonzaga -------------------------------------------------------------------------------- ℹ This PR was created on Tue, 04 Jun 2024 16:43:35 GMT ✔ Approvals: 7 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/53338#pullrequestreview-2100112730 ✔ - Ulises Gascón (@UlisesGascon): https://github.com/nodejs/node/pull/53338#pullrequestreview-2101440281 ✔ - Matteo Collina (@mcollina) (TSC): https://github.com/nodejs/node/pull/53338#pullrequestreview-2101528323 ✔ - Filip Skokan (@panva): https://github.com/nodejs/node/pull/53338#pullrequestreview-2101538471 ✔ - Tobias Nießen (@tniessen) (TSC): https://github.com/nodejs/node/pull/53338#pullrequestreview-2101739951 ✔ - Marco Ippolito (@marco-ippolito) (TSC): https://github.com/nodejs/node/pull/53338#pullrequestreview-2102071302 ✔ - Rafael Gonzaga (@RafaelGSS) (TSC): https://github.com/nodejs/node/pull/53338#pullrequestreview-2104359922 ✘ Last GitHub CI failed ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/9455025745 |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
There were some issues with the windows build CI that caused it to fail, can we land manually or rerun the CI if the issues are fixed? |
Sorry, something went wrong.
Ayase-252
approved these changes
Jun 17, 2024
targos
pushed a commit
that referenced
this pull request
Jun 20, 2024
PR-URL: #53338 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Qingyu Deng <i@ayase-lab.com>
soophoo
pushed a commit
to soophoo/node
that referenced
this pull request
Jun 20, 2024
PR-URL: nodejs#53338 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Qingyu Deng <i@ayase-lab.com>
marco-ippolito
pushed a commit
that referenced
this pull request
Jul 19, 2024
PR-URL: #53338 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Qingyu Deng <i@ayase-lab.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
11 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Github First-Time contributor badge has gone some changes since this image was taken, and I'm sure there will be more changes to it in the future. I don't think it's worth it to store this label as a photo, as the badge can be represented almost the exact same using text.