FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

doc: mark WebSocket as stable by KhafraDev · Pull Request #53352 · nodejs/node · GitHub

/ node Public

doc: mark WebSocket as stable - #53352

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
KhafraDev:websocket-stable
Jun 7, 2024
ConversationCommits (1)ChecksFiles changed
Merged

doc: mark WebSocket as stable#53352
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
KhafraDev:websocket-stable

Conversation

KhafraDev commented Jun 5, 2024

Copy link
Copy Markdown
Member

Notable change text:
The global WebSocket client is now stable

KhafraDev added the notable-change PRs with changes that should be highlighted in changelogs. label Jun 5, 2024

github-actions Bot commented Jun 5, 2024

Copy link
Copy Markdown
Contributor

The notable-change PRs with changes that should be highlighted in changelogs. label has been added by @KhafraDev.

Please suggest a text for the release notes if you'd like to include a more detailed summary, then proceed to update the PR description with the text or a link to the notable change suggested text comment. Otherwise, the commit will be placed in the Other Notable Changes section.

nodejs-github-bot added the doc Issues and PRs related to the documentations. label Jun 5, 2024
avivkeller added the web-standards Issues and PRs related to Web APIs label Jun 5, 2024

avivkeller commented Jun 5, 2024

Copy link
Copy Markdown
Member

web-standards from https://websockets.spec.whatwg.org/, right?

KhafraDev commented Jun 5, 2024

Copy link
Copy Markdown
Member Author

Yes, thank you

avivkeller commented Jun 5, 2024

Copy link
Copy Markdown
Member

I'm no expert on the stabilization process, but wouldn't the --no-experimental-websocket flag need to be removed?

anonrig reviewed Jun 5, 2024
View reviewed changes

anonrig left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Why are we making it stable now? Do we have good enough performance, stability across the api?

KhafraDev commented Jun 5, 2024 •
edited
Loading

Copy link
Copy Markdown
Member Author

I'm no expert on the stabilization process, but wouldn't the --no-experimental-websocket flag need to be removed?

This is only marking it as stable in the docs. Fetch is stable but --no-experimental-fetch flag still functions.

Why are we making it stable now? Do we have good enough performance, stability across the api?

I'm confident that it's stable now. We run the Autobahn test suite (the gold standard for WebSocket tests that pretty much everything that implements WebSocket uses) and pass 100% of the tests. Performance is another issue; fetch was also exposed globally before real benchmarking & perf improvements were done to it.

anonrig commented Jun 5, 2024

Copy link
Copy Markdown
Member

Thanks for the explanation @KhafraDev. I'm much more confident to approve this right now.

KhafraDev added author ready PRs that have at least one approval, no outstanding review comments, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Jun 5, 2024
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jun 5, 2024

This comment was marked as outdated.

Sign in to view

nodejs-github-bot commented Jun 6, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/59667/

KhafraDev added the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 6, 2024
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 7, 2024
nodejs-github-bot merged commit 0289e85 into nodejs:main Jun 7, 2024

nodejs-github-bot commented Jun 7, 2024

Copy link
Copy Markdown
Collaborator

Landed in 0289e85

KhafraDev deleted the websocket-stable branch June 7, 2024 18:00
targos pushed a commit that referenced this pull request Jun 20, 2024
doc: mark WebSocket as stable
16c0884 
PR-URL: #53352
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
soophoo pushed a commit to soophoo/node that referenced this pull request Jun 20, 2024
doc: mark WebSocket as stable
ad96d37 
PR-URL: nodejs#53352
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
targos added a commit that referenced this pull request Jun 25, 2024
2024-06-26, Version 22.4.0 (Current)
8efb279 
Notable changes:

deps,lib,src:
  * (SEMVER-MINOR) add experimental web storage (Colin Ihrig) #52435
doc:
  * move `node --run` stability to rc (Yagiz Nizipli) #53433
  * mark WebSocket as stable (Matthew Aitken) #53352
  * mark --heap-prof and related flags stable (Joyee Cheung) #53343
  * mark --cpu-prof and related flags stable (Joyee Cheung) #53343
  * doc-only deprecate OpenSSL engine-based APIs (Richard Lau) #53329
inspector:
  * fix disable async hooks on Debugger.setAsyncCallStackDepth (Joyee Cheung) #53473
lib:
  * (SEMVER-MINOR) add diagnostics_channel events to module loading (RafaelGSS) #44340
util:
  * (SEMVER-MINOR) support `--no-` for argument with boolean type for parseArgs (Zhenwei Jin) #53107

PR-URL: #53583
targos mentioned this pull request Jun 25, 2024
Merged
targos added a commit that referenced this pull request Jun 26, 2024
2024-06-26, Version 22.4.0 (Current)
e7e7e93 
Notable changes:

deps,lib,src:
  * (SEMVER-MINOR) add experimental web storage (Colin Ihrig) #52435
doc:
  * move `node --run` stability to rc (Yagiz Nizipli) #53433
  * mark WebSocket as stable (Matthew Aitken) #53352
  * mark --heap-prof and related flags stable (Joyee Cheung) #53343
  * mark --cpu-prof and related flags stable (Joyee Cheung) #53343
  * doc-only deprecate OpenSSL engine-based APIs (Richard Lau) #53329
inspector:
  * fix disable async hooks on Debugger.setAsyncCallStackDepth (Joyee Cheung) #53473
lib:
  * (SEMVER-MINOR) add diagnostics_channel events to module loading (RafaelGSS) #44340
util:
  * (SEMVER-MINOR) support `--no-` for argument with boolean type for parseArgs (Zhenwei Jin) #53107

PR-URL: #53583
targos added a commit that referenced this pull request Jul 1, 2024
2024-07-02, Version 22.4.0 (Current)
7e13cc5 
Notable changes:

deps,lib,src:
  * (SEMVER-MINOR) add experimental web storage (Colin Ihrig) #52435
doc:
  * move `node --run` stability to rc (Yagiz Nizipli) #53433
  * mark WebSocket as stable (Matthew Aitken) #53352
  * mark --heap-prof and related flags stable (Joyee Cheung) #53343
  * mark --cpu-prof and related flags stable (Joyee Cheung) #53343
  * doc-only deprecate OpenSSL engine-based APIs (Richard Lau) #53329
inspector:
  * fix disable async hooks on Debugger.setAsyncCallStackDepth (Joyee Cheung) #53473
lib:
  * (SEMVER-MINOR) add diagnostics_channel events to module loading (RafaelGSS) #44340
util:
  * (SEMVER-MINOR) support `--no-` for argument with boolean type for parseArgs (Zhenwei Jin) #53107

PR-URL: #53583
targos added a commit that referenced this pull request Jul 2, 2024
2024-07-02, Version 22.4.0 (Current)
056f055 
Notable changes:

deps,lib,src:
  * (SEMVER-MINOR) add experimental web storage (Colin Ihrig) #52435
doc:
  * move `node --run` stability to rc (Yagiz Nizipli) #53433
  * mark WebSocket as stable (Matthew Aitken) #53352
  * mark --heap-prof and related flags stable (Joyee Cheung) #53343
  * mark --cpu-prof and related flags stable (Joyee Cheung) #53343
  * doc-only deprecate OpenSSL engine-based APIs (Richard Lau) #53329
inspector:
  * fix disable async hooks on Debugger.setAsyncCallStackDepth (Joyee Cheung) #53473
lib:
  * (SEMVER-MINOR) add diagnostics_channel events to module loading (RafaelGSS) #44340
util:
  * (SEMVER-MINOR) support `--no-` for argument with boolean type for parseArgs (Zhenwei Jin) #53107

PR-URL: #53583
Karliz24 mentioned this pull request Jul 9, 2024
Open
coderabbitai Bot mentioned this pull request Apr 2, 2026
Closed
6 tasks
coderabbitai Bot mentioned this pull request May 8, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

benjamingr benjamingr approved these changes
anonrig anonrig approved these changes
trivikr trivikr approved these changes
+1 more reviewer
VoltrexKeyva VoltrexKeyva approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. doc Issues and PRs related to the documentations. notable-change PRs with changes that should be highlighted in changelogs. web-standards Issues and PRs related to Web APIs

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

Back | FazBrowse Home | New Git URL