| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
|
Review requested:
|
Sorry, something went wrong.
Sorry, something went wrong.
|
Windows CI is failing because... Windows. 2024-06-06T15:25:23.0802199Z D:\a\node\node\deps\v8\src\compiler\turboshaft\opmasks.h(150,75): error C2100: you cannot dereference an operand of type 'v8::internal::compiler::turboshaft::WordRepresentation' [D:\a\node\node\tools\v8_gypfiles\v8_turboshaft.vcxproj] 2024-06-06T15:25:23.2734105Z D:\a\node\node\deps\v8\src\compiler\turboshaft\opmasks.h(136,15): fatal error C1907: unable to recover from previous error(s); stopping compilation [D:\a\node\node\tools\v8_gypfiles\v8_turboshaft.vcxproj] 2024-06-06T15:25:23.2738599Z D:\a\node\node\deps\v8\src\compiler\turboshaft\representations.h(457,49): message : while evaluating constexpr function 'v8::internal::compiler::turboshaft::WordRepresentation::value' [D:\a\node\node\tools\v8_gypfiles\v8_turboshaft.vcxproj] 2024-06-06T15:25:23.2743220Z D:\a\node\node\deps\v8\src\compiler\turboshaft\opmasks.h(150,75): message : while evaluating constexpr function 'v8::internal::compiler::turboshaft::WordRepresentation::operator v8::internal::compiler::turboshaft::WordRepresentation::Enum' [D:\a\node\node\tools\v8_gypfiles\v8_turboshaft.vcxproj] 2024-06-06T15:25:23.2746822Z INTERNAL COMPILER ERROR in 'C:\Program Files\Microsoft Visual Studio\2022\Enterprise\VC\Tools\MSVC\14.40.33807\bin\HostX64\x64\CL.exe' 2024-06-06T15:25:23.2748408Z Please choose the Technical Support command on the Visual C++ 2024-06-06T15:25:23.2749476Z Help menu, or open the Technical Support help file for more information |
Sorry, something went wrong.
Both OpenSSL 1.1.1 and 3.x support SSL_get_peer_tmp_key as a replacement for SSL_get_server_tmp_key. While the old function name still exists as an alias, it does not accurately reflect the function's behavior (anymore). Hence, use the new function name here.
Sorry, something went wrong.
Commit Queue failed- Loading data for nodejs/node/pull/53366 ✔ Done loading data for nodejs/node/pull/53366 ----------------------------------- PR info ------------------------------------ Title tls: use SSL_get_peer_tmp_key (#53366) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch tniessen:ssl-get-peer-tmp-key -> nodejs:main Labels tls, crypto, c++, openssl, needs-ci Commits 1 - tls: use SSL_get_peer_tmp_key Committers 1 - Tobias Nießen PR-URL: https://github.com/nodejs/node/pull/53366 Reviewed-By: Filip Skokan Reviewed-By: Tim Perry Reviewed-By: Richard Lau Reviewed-By: Luigi Pinca Reviewed-By: Yagiz Nizipli ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/53366 Reviewed-By: Filip Skokan Reviewed-By: Tim Perry Reviewed-By: Richard Lau Reviewed-By: Luigi Pinca Reviewed-By: Yagiz Nizipli -------------------------------------------------------------------------------- ⚠ Commits were pushed since the last approving review: ⚠ - tls: use SSL_get_peer_tmp_key ℹ This PR was created on Thu, 06 Jun 2024 14:41:06 GMT ✔ Approvals: 5 ✔ - Filip Skokan (@panva): https://github.com/nodejs/node/pull/53366#pullrequestreview-2102193493 ✔ - Tim Perry (@pimterry): https://github.com/nodejs/node/pull/53366#pullrequestreview-2102209818 ✔ - Richard Lau (@richardlau) (TSC): https://github.com/nodejs/node/pull/53366#pullrequestreview-2102272801 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/53366#pullrequestreview-2103101790 ✔ - Yagiz Nizipli (@anonrig): https://github.com/nodejs/node/pull/53366#pullrequestreview-2103961048 ✔ Last GitHub CI successful ℹ Last Full PR CI on 2024-06-10T21:32:13Z: https://ci.nodejs.org/job/node-test-pull-request/59718/ - Querying data for job/node-test-pull-request/59718/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/9501496421 |
Sorry, something went wrong.
Both OpenSSL 1.1.1 and 3.x support SSL_get_peer_tmp_key as a replacement for SSL_get_server_tmp_key. While the old function name still exists as an alias, it does not accurately reflect the function's behavior (anymore). Hence, use the new function name here. PR-URL: #53366 Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Tim Perry <pimterry@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Both OpenSSL 1.1.1 and 3.x support SSL_get_peer_tmp_key as a replacement for SSL_get_server_tmp_key. While the old function name still exists as an alias, it does not accurately reflect the function's behavior (anymore). Hence, use the new function name here. PR-URL: nodejs#53366 Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Tim Perry <pimterry@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Both OpenSSL 1.1.1 and 3.x support SSL_get_peer_tmp_key as a replacement for SSL_get_server_tmp_key. While the old function name still exists as an alias, it does not accurately reflect the function's behavior (anymore). Hence, use the new function name here. PR-URL: #53366 Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Tim Perry <pimterry@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
* chore: bump node in DEPS to v20.16.0 * test: skip unstable shadow realm gc tests nodejs/node#52855 * test: extend env for `test-node-output-errors` nodejs/node#53535 * src: fix typo in env.cc nodejs/node#53418 * src: reset `process.versions` during pre-execution nodejs/node#53444 * chore: fixup patch indices * src,permission: --allow-wasi & prevent WASI exec nodejs/node#53124 * tls: use SSL_get_peer_tmp_key nodejs/node#53366 * deps: update c-ares to 1.29.0 nodejs/node#53155 * src: account for OpenSSL unexpected version * crypto: fix propagation of "memory limit exceeded" nodejs/node#53300 * process: add process.getBuiltinModule(id) nodejs/node#52762 * windows 32bit: config change callback needs to be stdcall c-ares/c-ares@8f265c9 * fix: building with UNICODE c-ares/c-ares#802 --------- Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com> Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com> Co-authored-by: Keeley Hammond <khammond@slack-corp.com>
| Back | FazBrowse Home | New Git URL |
Both OpenSSL 1.1.1 and 3.x support SSL_get_peer_tmp_key as a replacement for SSL_get_server_tmp_key. While the old function name still exists as an alias, it does not accurately reflect the function's behavior (anymore). Hence, use the new function name here.