tools: fix c-ares update script - #53414
Merged
nodejs-github-bot merged 1 commit intoJun 13, 2024
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
|
Review requested:
|
Sorry, something went wrong.
marco-ippolito
force-pushed
the
feat/fix-c-ares-script
branch
2 times, most recently
from
22fc5a7 to
64248a8
Compare
June 11, 2024 07:42
This comment was marked as resolved.
marco-ippolito
force-pushed
the
feat/fix-c-ares-script
branch
from
64248a8 to
7edcb34
Compare
June 11, 2024 08:29
richardlau
approved these changes
Jun 11, 2024
RafaelGSS
approved these changes
Jun 11, 2024
lpinca
approved these changes
Jun 11, 2024
soophoo
pushed a commit
to soophoo/node
that referenced
this pull request
Jun 20, 2024
PR-URL: nodejs#53414 Fixes: nodejs#53407 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #53407
Successful run https://github.com/nodejs/node/actions/runs/9461669085/job/26062910343
PR created: #53416