Revert "util: move util._extend to eol" - #53429
Merged
nodejs-github-bot merged 1 commit intoJun 14, 2024
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
This reverts commit ac97a53.
mcollina
approved these changes
Jun 12, 2024
mcollina
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
lgtm
Sorry, something went wrong.
mcollina
approved these changes
Jun 12, 2024
mcollina
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
lgtm
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
lpinca
approved these changes
Jun 12, 2024
MoLow
approved these changes
Jun 13, 2024
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
jasnell
approved these changes
Jun 14, 2024
soophoo
pushed a commit
to soophoo/node
that referenced
this pull request
Jun 20, 2024
This reverts commit ac97a53. PR-URL: nodejs#53429 Refs: tape-testing/tape#607 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: James M Snell <jasnell@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit ac97a53.
Refs: tape-testing/tape#607
It seems util._extend is used by old versions of debug (< v2.6.7) which is still widely used, so we might want to wait a bit before moving this to EOL
CC @mcollina @ljharb