lib: support promise reject for http2.connect promisify integration - #53475
Closed
ehsankhfr wants to merge 6 commits into
Closed
lib: support promise reject for http2.connect promisify integration#53475ehsankhfr wants to merge 6 commits into
ehsankhfr wants to merge 6 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
|
Review requested:
|
Sorry, something went wrong.
pimterry
requested changes
Jun 17, 2024
pimterry
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Good idea! Two small comments but this definitely seems useful to me 👍
Sorry, something went wrong.
Comment thread
test/parallel/test-http2-client-promisify-connect.js
Outdated
Comment thread
lib/internal/http2/core.js
mcollina
approved these changes
Jun 17, 2024
mcollina
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
lgtm
Sorry, something went wrong.
This comment was marked as outdated.
Comment thread
test/parallel/test-http2-client-promisify-connect.js
Outdated
Copy link
Copy Markdown
Contributor
Author
|
@pimterry @marco-ippolito thanks for your comments, the requested changes are done |
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Comment thread
lib/internal/http2/core.js
marco-ippolito
approved these changes
Jun 18, 2024
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
pimterry
approved these changes
Jun 18, 2024
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
pimterry
pushed a commit
that referenced
this pull request
Jun 20, 2024
PR-URL: #53475 Reviewed-By: Tim Perry <pimterry@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
targos
pushed a commit
that referenced
this pull request
Jun 20, 2024
PR-URL: #53475 Reviewed-By: Tim Perry <pimterry@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
soophoo
pushed a commit
to soophoo/node
that referenced
this pull request
Jun 20, 2024
PR-URL: nodejs#53475 Reviewed-By: Tim Perry <pimterry@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
marco-ippolito
pushed a commit
that referenced
this pull request
Jul 19, 2024
PR-URL: #53475 Reviewed-By: Tim Perry <pimterry@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR enhances the connect function to support Promise-based usage, adding error handling to the Promise wrapper to reject the Promise if an error occurs during the session's connect event.