FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

doc: only apply content-visibility on all.html by panva · Pull Request #53510 · nodejs/node · GitHub

/ node Public

doc: only apply content-visibility on all.html - #53510

Merged
nodejs-github-bot merged 2 commits into
nodejs:mainfrom
panva:doc-content-visibility
Jun 19, 2024
ConversationCommits (2)ChecksFiles changed
Merged

doc: only apply content-visibility on all.html#53510
nodejs-github-bot merged 2 commits into
nodejs:mainfrom
panva:doc-content-visibility

Conversation

panva commented Jun 19, 2024

Copy link
Copy Markdown
Member

Refs: #40099 (comment)

content-visibility is the source of bad anchor scrolling behaviours in select browsers that support this rule. This change makes it only apply to the sections in the all.html docs page.

nodejs-github-bot commented Jun 19, 2024

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/nodejs-website

nodejs-github-bot added the doc Issues and PRs related to the documentations. label Jun 19, 2024
panva mentioned this pull request Jun 19, 2024
Closed
aduh95 approved these changes Jun 19, 2024
View reviewed changes
Comment thread doc/api_assets/style.css Outdated
Update doc/api_assets/style.css
fa9ae9c 
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
panva added commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. author ready PRs that have at least one approval, no outstanding review comments, and a CI started. labels Jun 19, 2024
MoLow added the fast-track PRs that do not need to wait for 48 hours to land. label Jun 19, 2024

github-actions Bot commented Jun 19, 2024

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @MoLow. Please 👍 to approve.

MoLow commented Jun 19, 2024

Copy link
Copy Markdown
Member

I suggest we get this out as fast as possible @nodejs/releasers

ovflowd commented Jun 19, 2024

Copy link
Copy Markdown
Member

Feel free to fast-track this. Also indeed, releases if this could be patched on current live API docs (cc @nodejs/build)

richardlau commented Jun 19, 2024

Copy link
Copy Markdown
Member

Feel free to fast-track this. Also indeed, releases if this could be patched on current live API docs (cc @nodejs/build)

This cannot be patched on the current docs and would need new releases.

panva added the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 19, 2024
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 19, 2024
nodejs-github-bot merged commit 67c19c2 into nodejs:main Jun 19, 2024

nodejs-github-bot commented Jun 19, 2024

Copy link
Copy Markdown
Collaborator

Landed in 67c19c2

panva deleted the doc-content-visibility branch June 19, 2024 17:22
targos pushed a commit that referenced this pull request Jun 20, 2024
doc: only apply content-visibility on all.html
a5852cc 
Refs: #40099
PR-URL: #53510
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Claudio Wunder <cwunder@gnome.org>
soophoo pushed a commit to soophoo/node that referenced this pull request Jun 20, 2024
doc: only apply content-visibility on all.html
414c598 
Refs: nodejs#40099
PR-URL: nodejs#53510
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Claudio Wunder <cwunder@gnome.org>
targos mentioned this pull request Jun 25, 2024
Merged
valadaptive mentioned this pull request Jun 29, 2024
Closed
Karliz24 mentioned this pull request Jul 9, 2024
Open
marco-ippolito pushed a commit that referenced this pull request Jul 19, 2024
doc: only apply content-visibility on all.html
7c3edd9 
Refs: #40099
PR-URL: #53510
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Claudio Wunder <cwunder@gnome.org>
marco-ippolito mentioned this pull request Jul 19, 2024
Merged
marco-ippolito mentioned this pull request Nov 2, 2024
Closed
aduh95 mentioned this pull request Nov 7, 2024
Merged
aduh95 pushed a commit that referenced this pull request Nov 7, 2024
doc: only apply content-visibility on all.html
e4739e9 
Refs: #40099
PR-URL: #53510
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Claudio Wunder <cwunder@gnome.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

MoLow MoLow approved these changes
ovflowd ovflowd approved these changes
aduh95 aduh95 approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL