doc: recommend not using libuv node-api function - #53521
Closed
mhdawson wants to merge 5 commits into
Closed
Conversation
- update documentation recommend not using the napi_get_uv_event_loop function. It should not be need for most if not all uses cases now that the API is more complete. Signed-off-by: Michael Dawson <midawson@redhat.com>
Copy link
Copy Markdown
Collaborator
|
Review requested:
|
Sorry, something went wrong.
lpinca
approved these changes
Jun 20, 2024
legendecas
approved these changes
Jun 20, 2024
NickNaso
approved these changes
Jun 20, 2024
Comment thread
doc/api/n-api.md
aymen94
approved these changes
Jun 21, 2024
gabrielschulhof
approved these changes
Jun 21, 2024
Copy link
Copy Markdown
Member
Author
|
From discussion in Node-api team meeting today we should also add this to the function #if defined(__cplusplus) && __cplusplus >= 201402L
[[deprecated]]
#endifso that users will get deprecation warnings, and possibly create a re-usable definition. |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
After more discussion, will not include deprecation in c code. Starting with doc only deprecation, then at some later time drecating in the code. |
Sorry, something went wrong.
Co-authored-by: Gabriel Schulhof <gabrielschulhof@gmail.com>
Co-authored-by: Gabriel Schulhof <gabrielschulhof@gmail.com>
Comment thread
doc/api/n-api.md
Outdated
marco-ippolito
approved these changes
Jun 24, 2024
Co-authored-by: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
mhdawson
added a commit
that referenced
this pull request
Jun 24, 2024
- update documentation recommend not using the napi_get_uv_event_loop function. It should not be need for most if not all uses cases now that the API is more complete. Signed-off-by: Michael Dawson <midawson@redhat.com> PR-URL: #53521 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Gabriel Schulhof <gabrielschulhof@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
targos
pushed a commit
that referenced
this pull request
Jun 25, 2024
- update documentation recommend not using the napi_get_uv_event_loop function. It should not be need for most if not all uses cases now that the API is more complete. Signed-off-by: Michael Dawson <midawson@redhat.com> PR-URL: #53521 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Gabriel Schulhof <gabrielschulhof@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
marco-ippolito
pushed a commit
that referenced
this pull request
Jul 19, 2024
- update documentation recommend not using the napi_get_uv_event_loop function. It should not be need for most if not all uses cases now that the API is more complete. Signed-off-by: Michael Dawson <midawson@redhat.com> PR-URL: #53521 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Gabriel Schulhof <gabrielschulhof@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.