Revert "build: only generate specified build type files" - #53580
Merged
nodejs-github-bot merged 1 commit intoJun 26, 2024
Merged
Revert "build: only generate specified build type files"#53580nodejs-github-bot merged 1 commit into
nodejs-github-bot merged 1 commit into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
This reverts commit 6cb940a.
targos
approved these changes
Jun 25, 2024
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
richardlau
approved these changes
Jun 25, 2024
lpinca
approved these changes
Jun 25, 2024
Copy link
Copy Markdown
Contributor
|
Fast-track has been requested by @legendecas. Please 👍 to approve. |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
Fast-tracking the revert to fix the ninja workflow composing with make. |
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 6cb940a.
Refs: #53511 (comment)
I think an alternative should be making the generated config.gypi works in both Release mode and Debug mode.