FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

doc: add more details for localStorage and sessionStorage by Rekl0w · Pull Request #53881 · nodejs/node · GitHub

/ node Public

doc: add more details for localStorage and sessionStorage - #53881

Merged
nodejs-github-bot merged 27 commits into
nodejs:mainfrom
Rekl0w:Fix#53871
Sep 20, 2024
ConversationCommits (27)ChecksFiles changed
Merged

doc: add more details for localStorage and sessionStorage#53881
nodejs-github-bot merged 27 commits into
nodejs:mainfrom
Rekl0w:Fix#53871

Conversation

Rekl0w commented Jul 17, 2024

Copy link
Copy Markdown
Contributor

doc: add more details for localStorage and sessionStorage

Releated #53871

nodejs-github-bot added the doc Issues and PRs related to the documentations. label Jul 17, 2024
mertcanaltin approved these changes Jul 17, 2024
View reviewed changes

mertcanaltin left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

avivkeller commented Jul 17, 2024

Copy link
Copy Markdown
Member

CC @cjihrig

avivkeller reviewed Jul 17, 2024
View reviewed changes
Comment thread doc/api/globals.md Outdated
avivkeller reviewed Jul 17, 2024
View reviewed changes
Comment thread doc/api/globals.md Outdated
Comment thread doc/api/globals.md Outdated
Rekl0w and others added 2 commits July 17, 2024 22:43
Update doc/api/globals.md
071dd6b 
Co-authored-by: Aviv Keller <38299977+RedYetiDev@users.noreply.github.com>
Update doc/api/globals.md
10aae0f 
Co-authored-by: Aviv Keller <38299977+RedYetiDev@users.noreply.github.com>
cjihrig reviewed Jul 18, 2024
View reviewed changes
Comment thread doc/api/cli.md Outdated
Comment thread doc/api/globals.md Outdated
Comment thread doc/api/globals.md

avivkeller commented Jul 18, 2024

Copy link
Copy Markdown
Member

Please run make format-md when you get a change, It'll format the document.

Rekl0w commented Jul 19, 2024

Copy link
Copy Markdown
Contributor Author

I use windows, i can get help for formatting.

Rekl0w commented Jul 22, 2024

Copy link
Copy Markdown
Contributor Author

Any updates here ? @redyetidev

mertcanaltin commented Jul 25, 2024 •
edited
Loading

Copy link
Copy Markdown
Member

I use windows, i can get help for formatting.

You can use vcbuild after installing the vcbuild lint command will work for you, if you encounter any problems, please feel free to write

in addition some information about windows is here: windows doc

mertcanaltin reviewed Jul 25, 2024
View reviewed changes
Comment thread doc/api/globals.md Outdated

Rekl0w commented Aug 12, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

I used it but there are no changes in the files. @mertcanaltin

mertcanaltin commented Aug 13, 2024

Copy link
Copy Markdown
Member

I wonder if there is any warning message, what do you see as output

Rekl0w commented Aug 13, 2024

Copy link
Copy Markdown
Contributor Author

There is no warning message. I also tried an extension called markdownlint on VS Code, no diff.

mertcanaltin commented Aug 15, 2024

Copy link
Copy Markdown
Member

I have made an arrangement for you in my local, you can update it from here
mertcanaltin@ff78d56

Rekl0w commented Aug 15, 2024

Copy link
Copy Markdown
Contributor Author

Really appreciate that, thank you. @mertcanaltin

avivkeller reviewed Aug 16, 2024
View reviewed changes

avivkeller left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Looks like it still needs to be formatted, but content-wise LGTM (but I'm not a core collaborator)

Rekl0w commented Aug 19, 2024

Copy link
Copy Markdown
Contributor Author

Then it is up to you @cjihrig.

Rekl0w and others added 4 commits August 21, 2024 08:31
Update doc/api/globals.md
683ee9f 
Co-authored-by: Aviv Keller <38299977+RedYetiDev@users.noreply.github.com>
Update doc/api/globals.md
5d6e9b6 
Co-authored-by: Aviv Keller <38299977+RedYetiDev@users.noreply.github.com>
Update doc/api/globals.md
7b497da 
Co-authored-by: Aviv Keller <38299977+RedYetiDev@users.noreply.github.com>
Update doc/api/globals.md
43ae345 
Co-authored-by: Aviv Keller <38299977+RedYetiDev@users.noreply.github.com>
avivkeller reviewed Aug 21, 2024
View reviewed changes
Comment thread doc/api/globals.md Outdated
cjihrig reviewed Aug 23, 2024
View reviewed changes
Comment thread doc/api/globals.md Outdated
Comment thread doc/api/globals.md Outdated
Rekl0w and others added 2 commits August 23, 2024 16:38
Update doc/api/globals.md
58977b7 
Co-authored-by: Colin Ihrig <cjihrig@gmail.com>
doc: re-add webassembly-org
bb2275c
avivkeller added the commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. label Aug 23, 2024

Rekl0w commented Aug 23, 2024

Copy link
Copy Markdown
Contributor Author

I guess it is done now. @redyetidev @cjihrig

avivkeller reviewed Aug 26, 2024
View reviewed changes
Comment thread doc/api/globals.md Outdated
Update doc/api/globals.md
20cf144 
Co-authored-by: Aviv Keller <38299977+RedYetiDev@users.noreply.github.com>
avivkeller mentioned this pull request Aug 30, 2024
Closed

Rekl0w commented Sep 19, 2024

Copy link
Copy Markdown
Contributor Author

Any updates here ?

cjihrig added the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 20, 2024
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 20, 2024
nodejs-github-bot merged commit 99433a2 into nodejs:main Sep 20, 2024

nodejs-github-bot commented Sep 20, 2024

Copy link
Copy Markdown
Collaborator

Landed in 99433a2

cjihrig mentioned this pull request Sep 20, 2024
Closed
targos pushed a commit that referenced this pull request Oct 4, 2024
doc: add more details for localStorage and sessionStorage
4244f1a 
PR-URL: #53881
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
aduh95 mentioned this pull request Oct 9, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

avivkeller avivkeller left review comments
jasnell jasnell approved these changes
cjihrig cjihrig approved these changes
+1 more reviewer
mertcanaltin mertcanaltin approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. doc Issues and PRs related to the documentations.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

Back | FazBrowse Home | New Git URL