FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

build: update codecov by anonrig · Pull Request #53891 · nodejs/node · GitHub

/ node Public

build: update codecov - #53891

Closed
anonrig wants to merge 3 commits into
nodejs:mainfrom
anonrig:reenable-codecov
ConversationCommits (3)ChecksFiles changed
Closed

build: update codecov#53891
anonrig wants to merge 3 commits into
nodejs:mainfrom
anonrig:reenable-codecov

Conversation

anonrig commented Jul 17, 2024

Copy link
Copy Markdown
Member

Codecov comments were disabled almost 4 years ago. I think we can reenable them. Additionally, we now have 1 more coverage build. This PR fixes that.

Previous issue with codecov: #35759

cc @nodejs/build

anonrig requested a review from targos July 17, 2024 16:22
anonrig force-pushed the reenable-codecov branch from 0c24aa9 to 640af13 Compare July 17, 2024 16:24
anonrig force-pushed the reenable-codecov branch from 640af13 to 2c1be15 Compare July 17, 2024 16:27

targos commented Jul 17, 2024

Copy link
Copy Markdown
Member

In #35759 (comment), there was a coverage chart showing the issue. Can you post an updated one?

anonrig commented Jul 17, 2024

Copy link
Copy Markdown
Member Author

In #35759 (comment), there was a coverage chart showing the issue. Can you post an updated one?

I've reached out to Codecov teams, and with @bcoe working at Sentry, I have high hopes of fixing this soon!

anonrig mentioned this pull request Jul 17, 2024
Closed

avivkeller commented Jul 17, 2024

Copy link
Copy Markdown
Member

Would the landing of this PR close that issue? (So it can be closed once this lands if needed)

avivkeller added the meta Issues and PRs related to the general management of the project. label Jul 17, 2024
anonrig mentioned this pull request Jul 18, 2024
Closed

anonrig commented Jul 18, 2024

Copy link
Copy Markdown
Member Author

I've splitted the controversial changes, and moved the easy to review ones to #53929

Would the landing of this PR close that issue? (So it can be closed once this lands if needed)

No it won't.

bcoe commented Jul 25, 2024

Copy link
Copy Markdown
Contributor

@anonrig pulled the changes from this PR in here:

#54019

anonrig closed this Jul 25, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

targos Awaiting requested review from targos

Assignees

No one assigned

Labels

meta Issues and PRs related to the general management of the project.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL