FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fs: remove unnecessary option argument validation by JonasBa · Pull Request #53958 · nodejs/node · GitHub

/ node Public

fs: remove unnecessary option argument validation - #53958

Merged
nodejs-github-bot merged 3 commits into
nodejs:mainfrom
JonasBa:jb/fs-mkdir-options
Aug 6, 2024
Merged

fs: remove unnecessary option argument validation#53958
nodejs-github-bot merged 3 commits into
nodejs:mainfrom
JonasBa:jb/fs-mkdir-options

Conversation

JonasBa commented Jul 19, 2024

Copy link
Copy Markdown
Contributor

Remove unnecessary option parsing in mkdir

nodejs-github-bot added fs Issues and PRs related to the fs subsystem / file system. needs-ci PRs that need a full CI run. labels Jul 19, 2024
JonasBa force-pushed the jb/fs-mkdir-options branch from 6327d7b to f4e9f08 Compare July 19, 2024 21:24
Comment thread lib/fs.js Outdated
anonrig added the commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. label Jul 19, 2024
anonrig added the request-ci Add this label to start a Jenkins CI on a PR. label Jul 19, 2024
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 19, 2024

Copy link
Copy Markdown
Collaborator

anonrig added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Jul 19, 2024

aduh95 commented Jul 21, 2024

Copy link
Copy Markdown
Contributor

CI is failing

aduh95 removed the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Jul 21, 2024

anonrig commented Jul 21, 2024

Copy link
Copy Markdown
Member

CI is failing

I guess we are also testing the execution order here. We should update the tests @JonasBa

JonasBa commented Jul 26, 2024

Copy link
Copy Markdown
Contributor Author

Yeah, sorry about that. My device is managed and I cant change firewall rules to run the tests without getting a million connection popups

anonrig commented Jul 26, 2024

Copy link
Copy Markdown
Member

Yeah, sorry about that. My device is managed and I cant change firewall rules to run the tests without getting a million connection popups

You can run "tools/test.py path/to/test/file" for specific tests

Comment thread lib/fs.js Outdated
JonasBa force-pushed the jb/fs-mkdir-options branch from 20a13bf to 89a14bf Compare August 5, 2024 20:30

Copy link
Copy Markdown
Collaborator

JonasBa commented Aug 6, 2024

Copy link
Copy Markdown
Contributor Author

@anonrig is ti common for the build to run so long or did this timeout and needs a rerun? I dont see any failures, but I lack context on being able to tell how long this should take :)

anonrig commented Aug 6, 2024

Copy link
Copy Markdown
Member

@anonrig is ti common for the build to run so long or did this timeout and needs a rerun? I dont see any failures, but I lack context on being able to tell how long this should take :)

This is a timeout probably

Copy link
Copy Markdown
Collaborator

anonrig added the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 6, 2024
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 6, 2024
nodejs-github-bot merged commit 3ed9f98 into nodejs:main Aug 6, 2024

Copy link
Copy Markdown
Collaborator

Landed in 3ed9f98

JonasBa commented Aug 7, 2024

Copy link
Copy Markdown
Contributor Author

Thank you @anonrig 🙏🏼

targos pushed a commit that referenced this pull request Aug 14, 2024
PR-URL: #53958
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
RafaelGSS mentioned this pull request Aug 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. fs Issues and PRs related to the fs subsystem / file system. needs-ci PRs that need a full CI run.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants


Back | FazBrowse Home | New Git URL