Congrats on your first contribution! 🎉
Please update the commit message per the guide to fix the CI issue. Also, remove me as a co-author since I didn't directly contribute and don't qualify. :-)

The git config was not set up properly, so I committed it again. 😅

@aduh95 Thanks for the review!

It might be more wise to consider dirent.path irremediably broken and switch to using dirent.parentPath which is stable.

Does the above mean modifying the readSyncRecursive function to use parentPath instead of path?

// dir.js
readSyncRecursive(dirent) {
    const ctx = { path: dirent.parentPath };
    const handle = dirBinding.opendir(
      pathModule.toNamespacedPath(dirent.parentPath),
      this[kDirOptions].encoding,
      undefined,
      ctx,
    );
    handleErrorFromBinding(ctx);
    const result = handle.read(
      this[kDirOptions].encoding,
      this[kDirOptions].bufferSize,
      undefined,
      ctx,
    );

    if (result) {
      this.processReadResult(dirent.parentPath, result);
    }

    handle.close(undefined, ctx);
    handleErrorFromBinding(ctx);
  }

Could you please help me a little more?

Does the above mean modifying the readSyncRecursive function to use parentPath instead of path?

No I meant for user land, Im unsure fixing it in Node.js is worth it

This one is simply very hard to fix without introducing more breaking changes. It might be more wise to consider dirent.path irremediably broken and switch to using dirent.parentPath which is stable.

Doesn't make sense this statement since on the sync version we have the correct behavior, unless you want to change the sync version.

unless you want to change the sync version.

No that would be equally unwise IMO. What I'm saying is that dirent.path is inconsistent, and I don't see a way to fix the inconsistency without risking breaking more stuff. dirent.parentPath was introduced because dirent.path is inconsistent and unfortunately the ecosystem was/is relying on some of these inconsistencies.
If there's a way to bring back the behavior of v18.19.1 without breaking dirent.parentPath, I think we should consider doing so; I couldn't figure a way for doing so, I'm not saying it's impossible, but given the fact that v18.19.1 behavior is also inconsistent, I'm not sure it's worth doing.

I will wait for the direction of the work to be decided. If you decide, please let me know!