FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fs: fix regression on rmsync by anonrig · Pull Request #53982 · nodejs/node · GitHub

/ node Public

fs: fix regression on rmsync - #53982

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
anonrig:fix-regression-rmsync
Jul 23, 2024
ConversationCommits (1)ChecksFiles changed
Merged

fs: fix regression on rmsync#53982
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
anonrig:fix-regression-rmsync

Conversation

anonrig commented Jul 21, 2024 •
edited
Loading

Copy link
Copy Markdown
Member

The original implementation was using sleep(i * options.retryDelay);. While migrating to C++, we forgot that.

cc @nodejs/fs

nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. fs Issues and PRs related to the fs subsystem / file system. needs-ci PRs that need a full CI run. labels Jul 21, 2024
anonrig requested review from aduh95 and richardlau July 21, 2024 16:49
aduh95 approved these changes Jul 21, 2024
View reviewed changes

aduh95 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Any chance you could add a test?

anonrig commented Jul 21, 2024

Copy link
Copy Markdown
Member Author

Any chance you could add a test?

I couldn't find a reliable and non-flaky way to test this change.

anonrig added author ready PRs that have at least one approval, no outstanding review comments, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. request-ci Add this label to start a Jenkins CI on a PR. labels Jul 21, 2024
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 21, 2024

nodejs-github-bot commented Jul 21, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/60501/

nodejs-github-bot commented Jul 22, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/60520/

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 23, 2024
nodejs-github-bot merged commit cf2bce6 into nodejs:main Jul 23, 2024

nodejs-github-bot commented Jul 23, 2024

Copy link
Copy Markdown
Collaborator

Landed in cf2bce6

targos added dont-land-on-v18.x dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. labels Jul 30, 2024

targos commented Jul 30, 2024

Copy link
Copy Markdown
Member

Depends on #53617

aduh95 mentioned this pull request Oct 14, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jasnell jasnell approved these changes
aduh95 aduh95 approved these changes
richardlau Awaiting requested review from richardlau

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. fs Issues and PRs related to the fs subsystem / file system. needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL