FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

src: move spkac methods to ncrypto by jasnell · Pull Request #53985 · nodejs/node · GitHub

/ node Public

src: move spkac methods to ncrypto - #53985

Closed
jasnell wants to merge 1 commit into
nodejs:mainfrom
jasnell:jsnell/move-crypto-spkac-to-ncrypto
ConversationCommits (1)ChecksFiles changed
Closed

src: move spkac methods to ncrypto#53985
jasnell wants to merge 1 commit into
nodejs:mainfrom
jasnell:jsnell/move-crypto-spkac-to-ncrypto

Conversation

jasnell commented Jul 21, 2024

Copy link
Copy Markdown
Member

No description provided.

jasnell requested review from anonrig and tniessen July 21, 2024 22:59

nodejs-github-bot commented Jul 21, 2024

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/crypto
  • @nodejs/security-wg

nodejs-github-bot added lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Jul 21, 2024
jasnell added request-ci Add this label to start a Jenkins CI on a PR. and removed lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Jul 21, 2024
jasnell force-pushed the jsnell/move-crypto-spkac-to-ncrypto branch from ea5104c to 9afde2d Compare July 21, 2024 23:06
github-actions Bot added request-ci-failed An error occurred while starting CI via request-ci label, and manual interventon is needed. and removed request-ci Add this label to start a Jenkins CI on a PR. labels Jul 21, 2024

This comment was marked as outdated.

Sign in to view

nodejs-github-bot commented Jul 21, 2024 •
edited by jasnell
Loading

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/60518/ 💛

jasnell added crypto Issues and PRs related to the crypto subsystem. c++ Issues and PRs that require attention from people who are familiar with C++. and removed request-ci-failed An error occurred while starting CI via request-ci label, and manual interventon is needed. labels Jul 21, 2024

jasnell commented Jul 21, 2024

Copy link
Copy Markdown
Member Author

@nodejs/crypto

anonrig reviewed Jul 21, 2024
View reviewed changes
Comment thread deps/ncrypto/ncrypto.cc Outdated
Comment thread deps/ncrypto/ncrypto.cc Outdated
Comment thread deps/ncrypto/ncrypto.cc Outdated
Comment thread deps/ncrypto/ncrypto.cc Outdated
anonrig reviewed Jul 21, 2024
View reviewed changes
Comment thread deps/ncrypto/ncrypto.cc Outdated
anonrig reviewed Jul 21, 2024
View reviewed changes
Comment thread deps/ncrypto/ncrypto.cc Outdated
jasnell force-pushed the jsnell/move-crypto-spkac-to-ncrypto branch from 9afde2d to 17c1f41 Compare July 22, 2024 14:32
jasnell requested a review from anonrig July 22, 2024 14:35
anonrig reviewed Jul 22, 2024
View reviewed changes
Comment thread deps/ncrypto/ncrypto.cc
anonrig added author ready PRs that have at least one approval, no outstanding review comments, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Jul 22, 2024
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 22, 2024

This comment was marked as outdated.

Sign in to view

nodejs-github-bot commented Jul 22, 2024 •
edited by jasnell
Loading

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/60542/ 💛

anonrig added commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Jul 25, 2024
jasnell added a commit that referenced this pull request Aug 5, 2024
src: move spkac methods to ncrypto
cf21220 
PR-URL: #53985
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>

jasnell commented Aug 5, 2024

Copy link
Copy Markdown
Member Author

Landed in cf21220

jasnell closed this Aug 5, 2024
targos pushed a commit that referenced this pull request Aug 14, 2024
src: move spkac methods to ncrypto
e619133 
PR-URL: #53985
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
RafaelGSS mentioned this pull request Aug 19, 2024
Merged
npaun pushed a commit to npaun/ncrypto that referenced this pull request Sep 18, 2025
src: move spkac methods to ncrypto
126fcd7 
PR-URL: nodejs/node#53985
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

anonrig anonrig approved these changes
tniessen Awaiting requested review from tniessen

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. crypto Issues and PRs related to the crypto subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL