Review requested:

• @nodejs/test_runner

CI: https://ci.nodejs.org/job/node-test-pull-request/60583/

CI: https://ci.nodejs.org/job/node-test-pull-request/60589/

CI: https://ci.nodejs.org/job/node-test-pull-request/60591/

CI: https://ci.nodejs.org/job/node-test-pull-request/60593/

CI: https://ci.nodejs.org/job/node-test-pull-request/60623/

CI: https://ci.nodejs.org/job/node-test-pull-request/60626/

I've been trying to figure out how this seemingly very innocent change was introducing EPERM failures on Windows when trying to clean up the tmp directory. Then I saw the same failures in an unrelated CI run. So, I'm going to land this once I get a green CI.

It looks like the flaky test in question was introduced in #53866 (cc @mcollina).

Related to the EPERM issues - I only tried one run, but using fsPromises.rm() to perform the cleanup worked. I tried this after @richardlau called out the recent changes to rmSync(). Those changes in #53617 seem to have dropped code related to special handling of EPERM on Windows. That might be worth following up on.

CI: https://ci.nodejs.org/job/node-test-pull-request/60631/

- Loading data for nodejs/node/pull/54013
✔  Done loading data for nodejs/node/pull/54013
----------------------------------- PR info ------------------------------------
Title      test_runner: remove redundant bootstrap boolean (#54013)
Author     Colin Ihrig <cjihrig@gmail.com> (@cjihrig)
Branch     cjihrig:bootstrap -> nodejs:main
Labels     author ready, commit-queue-squash, test_runner
Commits    4
 - test_runner: remove redundant bootstrap boolean
 - hmm
 - ugh
 - Revert "ugh"
Committers 1
 - cjihrig <cjihrig@gmail.com>
PR-URL: https://github.com/nodejs/node/pull/54013
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/54013
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
--------------------------------------------------------------------------------
   ℹ  This PR was created on Wed, 24 Jul 2024 04:09:00 GMT
   ✔  Approvals: 3
   ✔  - Chemi Atlow (@atlowChemi): https://github.com/nodejs/node/pull/54013#pullrequestreview-2195620030
   ✔  - Yagiz Nizipli (@anonrig) (TSC): https://github.com/nodejs/node/pull/54013#pullrequestreview-2196305917
   ✔  - Moshe Atlow (@MoLow) (TSC): https://github.com/nodejs/node/pull/54013#pullrequestreview-2200309148
   ✘  Last GitHub CI failed
   ℹ  Last Full PR CI on 2024-07-25T22:32:06Z: https://ci.nodejs.org/job/node-test-pull-request/60631/
- Querying data for job/node-test-pull-request/60631/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu

@cjihrig this commit cannot land atm because GHA did not run for this.

CI: https://ci.nodejs.org/job/node-test-pull-request/60648/

Green CI + 3 approvals, is this PR ready to land?

because GHA did not run for this.

What is GHA? I tried to find it in glossary but not there yet 😄

edit: Oh is it Github Action?

Landed in 14e7eb3