FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

stream: Relocate the status checking code in the onWriteComplete by MCprotein · Pull Request #54032 · nodejs/node · GitHub

/ node Public

stream: Relocate the status checking code in the onWriteComplete - #54032

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
MCprotein:fix/stream-base-commons-todo
Sep 2, 2024
ConversationCommits (1)ChecksFiles changed
Merged

stream: Relocate the status checking code in the onWriteComplete#54032
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
MCprotein:fix/stream-base-commons-todo

Conversation

MCprotein commented Jul 25, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

Modified the code to check the status before verifying if the stream is destroyed.

error name refs:

/ / lib/internal/webstreams/adapter.js
  function onWriteComplete(status) {
    if (status < 0) {
      const error = new ErrnoException(status, 'write', this.error);
      this.promise.reject(error);
      this.controller.error(error);
      return;
    }
    this.promise.resolve();
  }

cc. @ronag

nodejs-github-bot added the needs-ci PRs that need a full CI run. label Jul 25, 2024
stream: relocate the status checking code in the onwritecomplete
2dddcdd 
relocate the status checking code before verifying if the stream is
destroyed
MCprotein force-pushed the fix/stream-base-commons-todo branch from 7066edb to 2dddcdd Compare July 25, 2024 06:14
jakecastelli added the stream Issues and PRs related to the stream subsystem. label Jul 27, 2024

jakecastelli commented Jul 27, 2024

Copy link
Copy Markdown
Member

cc. @nodejs/streams

benjamingr added the request-ci Add this label to start a Jenkins CI on a PR. label Jul 27, 2024

benjamingr commented Jul 27, 2024

Copy link
Copy Markdown
Member

I wonder how breaking this is, I'll also trigger a CITGM

benjamingr commented Jul 27, 2024

Copy link
Copy Markdown
Member

CITGM https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/3466/

github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 27, 2024

nodejs-github-bot commented Jul 27, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/60678/

ronag approved these changes Jul 27, 2024
View reviewed changes

ronag left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM assuming CITGM is ok

daeyeon commented Jul 28, 2024

Copy link
Copy Markdown
Member

module test suite failed
Error: The canary is dead:

CITGM currently has an issue that is being investigated under nodejs/citgm#1067.

nodejs-github-bot commented Jul 28, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/60683/

MCprotein commented Jul 29, 2024

Copy link
Copy Markdown
Contributor Author

CI: https://ci.nodejs.org/job/node-test-pull-request/60683/

@daeyeon
I think that the citgm is still unstable, should I wait for now?

daeyeon commented Jul 29, 2024

Copy link
Copy Markdown
Member

Yes. We need to wait until the citgm result is available. Thanks in advance for your patience.

MCprotein commented Jul 29, 2024

Copy link
Copy Markdown
Contributor Author

Yes. We need to wait until the citgm result is available. Thanks in advance for your patience.

thank you for explaining 😄

mcollina approved these changes Jul 29, 2024
View reviewed changes

mcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

lgtm with a green CITGM

mcollina commented Aug 2, 2024

Copy link
Copy Markdown
Member

CITGM: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/3467/

mcollina added baking-for-lts PRs that need to wait before landing in a LTS release. commit-queue Add this label to land a pull request using GitHub Actions. semver-minor PRs that contain new features and should be released in the next minor version. labels Sep 2, 2024
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 2, 2024
nodejs-github-bot merged commit 298dea0 into nodejs:main Sep 2, 2024

nodejs-github-bot commented Sep 2, 2024

Copy link
Copy Markdown
Collaborator

Landed in 298dea0

aduh95 pushed a commit that referenced this pull request Sep 12, 2024
stream: relocate the status checking code in the onwritecomplete
e2307d8 
relocate the status checking code before verifying if the stream is
destroyed

PR-URL: #54032
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
RafaelGSS mentioned this pull request Sep 16, 2024
Merged
RafaelGSS added a commit that referenced this pull request Sep 16, 2024
2024-09-17, Version 22.9.0 (Current)
9fcecb9 
Notable changes:

lib:
  * (SEMVER-MINOR) add util.getCallSite() API (Rafael Gonzaga) #54380
repl:
  * doc-deprecate instantiating `node:repl` classes without `new` (Aviv Keller) #54842
src:
  * create handle scope in FastInternalModuleStat (Joyee Cheung) #54384
stream:
  * (SEMVER-MINOR) relocate the status checking code in the onwritecomplete (YoonSoo_Shin) #54032
tls:
  * (SEMVER-MINOR) add `allowPartialTrustChain` flag (Anna Henningsen) #54790
v8:
  * Revert "v8: enable maglev on supported architectures (Joyee Cheung) #54384

PR-URL: #54966
RafaelGSS added a commit that referenced this pull request Sep 17, 2024
2024-09-17, Version 22.9.0 (Current)
85a9935 
Notable changes:

lib:
  * (SEMVER-MINOR) add util.getCallSite() API (Rafael Gonzaga) #54380
repl:
  * doc-deprecate instantiating `node:repl` classes without `new` (Aviv Keller) #54842
src:
  * create handle scope in FastInternalModuleStat (Joyee Cheung) #54384
stream:
  * (SEMVER-MINOR) relocate the status checking code in the onwritecomplete (YoonSoo_Shin) #54032
tls:
  * (SEMVER-MINOR) add `allowPartialTrustChain` flag (Anna Henningsen) #54790
v8:
  * Revert "v8: enable maglev on supported architectures (Joyee Cheung) #54384

PR-URL: #54966
RafaelGSS added a commit that referenced this pull request Sep 17, 2024
2024-09-17, Version 22.9.0 (Current)
4631be0 
Notable changes:

lib:
  * (SEMVER-MINOR) add util.getCallSite() API (Rafael Gonzaga) #54380
repl:
  * doc-deprecate instantiating `node:repl` classes without `new` (Aviv Keller) #54842
src:
  * create handle scope in FastInternalModuleStat (Joyee Cheung) #54384
stream:
  * (SEMVER-MINOR) relocate the status checking code in the onwritecomplete (YoonSoo_Shin) #54032
tls:
  * (SEMVER-MINOR) add `allowPartialTrustChain` flag (Anna Henningsen) #54790
v8:
  * Revert "v8: enable maglev on supported architectures (Joyee Cheung) #54384

PR-URL: #54966
RafaelGSS added a commit that referenced this pull request Sep 17, 2024
2024-09-17, Version 22.9.0 (Current)
e49cf7a 
Notable changes:

lib:
  * (SEMVER-MINOR) add util.getCallSite() API (Rafael Gonzaga) #54380
repl:
  * doc-deprecate instantiating `node:repl` classes without `new` (Aviv Keller) #54842
src:
  * create handle scope in FastInternalModuleStat (Joyee Cheung) #54384
stream:
  * (SEMVER-MINOR) relocate the status checking code in the onwritecomplete (YoonSoo_Shin) #54032
tls:
  * (SEMVER-MINOR) add `allowPartialTrustChain` flag (Anna Henningsen) #54790
v8:
  * Revert "v8: enable maglev on supported architectures (Joyee Cheung) #54384

PR-URL: #54966
aduh95 removed the baking-for-lts PRs that need to wait before landing in a LTS release. label Feb 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

mcollina mcollina approved these changes
jasnell jasnell approved these changes
ronag ronag approved these changes

Assignees

No one assigned

Labels

needs-ci PRs that need a full CI run. semver-minor PRs that contain new features and should be released in the next minor version. stream Issues and PRs related to the stream subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

Back | FazBrowse Home | New Git URL