FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

[v20.x backport] stream: implement `min` option for `ReadableStreamBYOBReader.read` by MattiasBuelens · Pull Request #54044 · nodejs/node · GitHub

/ node Public

[v20.x backport] stream: implement min option for ReadableStreamBYOBReader.read - #54044

Closed
MattiasBuelens wants to merge 2 commits into
nodejs:v20.x-stagingfrom
MattiasBuelens:backport-50888-to-v20.x
ConversationCommits (2)ChecksFiles changed
Closed

[v20.x backport] stream: implement min option for ReadableStreamBYOBReader.read#54044
MattiasBuelens wants to merge 2 commits into
nodejs:v20.x-stagingfrom
MattiasBuelens:backport-50888-to-v20.x

Conversation

MattiasBuelens commented Jul 25, 2024

Copy link
Copy Markdown
Contributor

Manual backport of #50888 to v20.x.

nodejs-github-bot commented Jul 25, 2024

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/web-standards

nodejs-github-bot added lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. v20.x labels Jul 25, 2024
stream: implement min option for ReadableStreamBYOBReader.read
22340d9 
PR-URL: nodejs#50888
Backport-PR-URL: nodejs#54044
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
MattiasBuelens force-pushed the backport-50888-to-v20.x branch from 33cc538 to 22340d9 Compare July 25, 2024 17:30

nodejs-github-bot commented Jul 25, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/60627/

nodejs-github-bot commented Jul 26, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/60642/

mcollina approved these changes Jul 26, 2024
View reviewed changes

mcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

lgtm

MattiasBuelens added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Jul 27, 2024
MattiasBuelens self-assigned this Jul 27, 2024
MattiasBuelens commented Jul 27, 2024
View reviewed changes
Comment thread doc/api/webstreams.md
MattiasBuelens removed the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Jul 27, 2024

mcollina commented Aug 2, 2024

Copy link
Copy Markdown
Member

cc @nodejs/releasers @RafaelGSS can you include this in the next v20?

MattiasBuelens added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Aug 2, 2024
RafaelGSS approved these changes Aug 2, 2024
View reviewed changes

RafaelGSS left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM.

Comment thread doc/api/webstreams.md

RafaelGSS commented Aug 2, 2024

Copy link
Copy Markdown
Member

cc @nodejs/releasers @RafaelGSS can you include this in the next v20?

Yes, whoever takes the lead on the next v20 release will merge this PR with staging.

marco-ippolito pushed a commit that referenced this pull request Aug 8, 2024
stream: implement min option for ReadableStreamBYOBReader.read
4a3ecbf 
PR-URL: #50888
Backport-PR-URL: #54044
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>

marco-ippolito commented Aug 8, 2024

Copy link
Copy Markdown
Member

Landed in 4a3ecbf

MattiasBuelens deleted the backport-50888-to-v20.x branch August 8, 2024 17:09
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

mcollina mcollina approved these changes
benjamingr benjamingr approved these changes
RafaelGSS RafaelGSS approved these changes
+1 more reviewer
aymen94 aymen94 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

MattiasBuelens

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. web streams

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

Back | FazBrowse Home | New Git URL