FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

doc: explicit about VS 2015 support in readme by phillipj · Pull Request #5406 · nodejs/node · GitHub

/ node Public

doc: explicit about VS 2015 support in readme - #5406

Closed
phillipj wants to merge 1 commit into
nodejs:masterfrom
phillipj:readme-vs2015
ConversationCommits (1)ChecksFiles changed
Closed

doc: explicit about VS 2015 support in readme#5406
phillipj wants to merge 1 commit into
nodejs:masterfrom
phillipj:readme-vs2015

Conversation

phillipj commented Feb 24, 2016

Copy link
Copy Markdown
Member

vcbuild.bat already supports both Visual Studio 2013 and 2015. Lets be explicit about it to avoid devs installing an old IDE.

mscdex added doc Issues and PRs related to the documentations. windows Issues and PRs related to the Windows platform. build Issues and PRs related to build files or the CI. labels Feb 24, 2016

rvagg commented Feb 24, 2016

Copy link
Copy Markdown
Member

Is the 2015 thing called "for Windows Desktop"?

rvagg commented Feb 24, 2016

Copy link
Copy Markdown
Member

@nodejs/platform-windows any input on clarifying exactly what's supported would be helpful

phillipj commented Feb 24, 2016

Copy link
Copy Markdown
Member Author

Is the 2015 thing called "for Windows Desktop"?

Yep. https://www.visualstudio.com/en-us/products/visual-studio-express-vs.aspx#scrum

orangemocha commented Feb 25, 2016

Copy link
Copy Markdown
Contributor

Visual Studio 2013 & 2015, all editions including the Community edition.
Visual Studio Express 2013 for Windows Desktop
Visual Studio Express 2015 for Desktop

orangemocha reviewed Feb 25, 2016
View reviewed changes
Comment thread README.md Outdated
* [Python 2.6 or 2.7](https://www.python.org/downloads/)
* Visual Studio 2013 for Windows Desktop, or
* Visual Studio Express 2013 for Windows Desktop
* Visual Studio 2013 / 2015 for Windows Desktop, or

orangemocha Feb 25, 2016

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

The full edition doesn't have a "for Windows Desktop" SKU. Only the Visual Studio Express does and it was called "for Windows Desktop" in 2013 and "for Desktop" in 2015.

doc: explicit about VS 2015 support in readme
6cf958e 
`vcbuild.bat` already supports both Visual Studio 2013 and 2015.

phillipj commented Feb 25, 2016

Copy link
Copy Markdown
Member Author

@orangemocha just pushed an updated.

Would you agree we can combine the express editions into one line of "for Desktop", rather than having two different lines just to get "for Windows Desktop" for VS Express 2013?

orangemocha commented Feb 25, 2016

Copy link
Copy Markdown
Contributor

Seems clear enough to me, but would like to get another +1.

LGTM

rvagg commented Feb 26, 2016

Copy link
Copy Markdown
Member

lgtm

rvagg commented Feb 26, 2016

Copy link
Copy Markdown
Member

landed @ 1d7c370, thanks @phillipj!

rvagg closed this Feb 26, 2016
rvagg pushed a commit that referenced this pull request Feb 26, 2016
doc: explicit about VS 2015 support in readme
1d7c370 
`vcbuild.bat` already supports both Visual Studio 2013 and 2015.

PR-URL: #5406
Reviewed-By: Alexis Campailla <orangemocha@nodejs.org>
Reviewed-By: Rod Vagg <rod@vagg.org>
rvagg pushed a commit that referenced this pull request Feb 27, 2016
doc: explicit about VS 2015 support in readme
275aa35 
`vcbuild.bat` already supports both Visual Studio 2013 and 2015.

PR-URL: #5406
Reviewed-By: Alexis Campailla <orangemocha@nodejs.org>
Reviewed-By: Rod Vagg <rod@vagg.org>
rvagg pushed a commit that referenced this pull request Feb 27, 2016
doc: explicit about VS 2015 support in readme
7f2cf9a 
`vcbuild.bat` already supports both Visual Studio 2013 and 2015.

PR-URL: #5406
Reviewed-By: Alexis Campailla <orangemocha@nodejs.org>
Reviewed-By: Rod Vagg <rod@vagg.org>
Fishrock123 mentioned this pull request Mar 1, 2016
Merged
5 tasks
MylesBorins pushed a commit that referenced this pull request Mar 1, 2016
doc: explicit about VS 2015 support in readme
14a4b73 
`vcbuild.bat` already supports both Visual Studio 2013 and 2015.

PR-URL: #5406
Reviewed-By: Alexis Campailla <orangemocha@nodejs.org>
Reviewed-By: Rod Vagg <rod@vagg.org>
MylesBorins pushed a commit that referenced this pull request Mar 1, 2016
doc: explicit about VS 2015 support in readme
394743f 
`vcbuild.bat` already supports both Visual Studio 2013 and 2015.

PR-URL: #5406
Reviewed-By: Alexis Campailla <orangemocha@nodejs.org>
Reviewed-By: Rod Vagg <rod@vagg.org>
MylesBorins pushed a commit that referenced this pull request Mar 2, 2016
doc: explicit about VS 2015 support in readme
ae347b5 
`vcbuild.bat` already supports both Visual Studio 2013 and 2015.

PR-URL: #5406
Reviewed-By: Alexis Campailla <orangemocha@nodejs.org>
Reviewed-By: Rod Vagg <rod@vagg.org>
Clemens-git76 mentioned this pull request Apr 16, 2024
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

build Issues and PRs related to build files or the CI. doc Issues and PRs related to the documentations. windows Issues and PRs related to the Windows platform.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL