typings: fix typo on quic onSessionDatagram - #54064
Merged
nodejs-github-bot merged 1 commit intoJul 29, 2024
Merged
Conversation
This was referenced Jul 27, 2024
H4ad
approved these changes
Jul 27, 2024
H4ad
reviewed
Jul 27, 2024
H4ad
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Can you change your commit message to be more clear about what are you fixing?
Something like: typings: fix typo on quic onSessionDatagram
Sorry, something went wrong.
1ilsang
force-pushed
the
fix/typings-typo
branch
from
bdb2c6b to
d2cf2df
Compare
July 27, 2024 15:34
Copy link
Copy Markdown
Member
Author
Sorry, something went wrong.
anonrig
approved these changes
Jul 27, 2024
deokjinkim
approved these changes
Jul 28, 2024
jakecastelli
approved these changes
Jul 28, 2024
lpinca
approved these changes
Jul 28, 2024
targos
pushed a commit
that referenced
this pull request
Jul 30, 2024
PR-URL: #54064 Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Deokjin Kim <deokjin81.kim@gmail.com> Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Merged
RafaelGSS
pushed a commit
that referenced
this pull request
Aug 5, 2024
PR-URL: #54064 Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Deokjin Kim <deokjin81.kim@gmail.com> Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.