FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

buffer: use native copy impl by ronag · Pull Request #54087 · nodejs/node · GitHub

/ node Public

buffer: use native copy impl - #54087

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
nxtedition:buffer-copy
Aug 2, 2024
ConversationCommits (1)ChecksFiles changed
Merged

buffer: use native copy impl#54087
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
nxtedition:buffer-copy

Conversation

ronag commented Jul 28, 2024 •
edited
Loading

Copy link
Copy Markdown
Member

Apple M2 Pro

buffers/buffer-copy.js n=6000000 partial='false' bytes=0                    -0.53 %       ±6.78%  ±9.02% ±11.74%
buffers/buffer-copy.js n=6000000 partial='false' bytes=128          ***     30.37 %      ±10.39% ±13.88% ±18.19%
buffers/buffer-copy.js n=6000000 partial='false' bytes=32768                 2.73 %       ±3.96%  ±5.27%  ±6.86%
buffers/buffer-copy.js n=6000000 partial='false' bytes=8            ***     73.09 %      ±10.43% ±13.89% ±18.08%
buffers/buffer-copy.js n=6000000 partial='true' bytes=0                     -1.66 %       ±7.78% ±10.35% ±13.47%
buffers/buffer-copy.js n=6000000 partial='true' bytes=128           ***    327.50 %      ±23.05% ±31.00% ±41.01%
buffers/buffer-copy.js n=6000000 partial='true' bytes=32768           *      4.50 %       ±4.34%  ±5.78%  ±7.55%
buffers/buffer-copy.js n=6000000 partial='true' bytes=8             ***    311.90 %      ±33.99% ±45.75% ±60.62%

Benchmark CI

10:33:07 buffers/buffer-copy.js n=6000000 partial='false' bytes=0                     0.56 %       ±1.11%  ±1.48%  ±1.95%
10:33:07 buffers/buffer-copy.js n=6000000 partial='false' bytes=128          ***     34.10 %       ±0.81%  ±1.08%  ±1.41%
10:33:07 buffers/buffer-copy.js n=6000000 partial='false' bytes=32768        ***     -1.80 %       ±0.84%  ±1.12%  ±1.47%
10:33:07 buffers/buffer-copy.js n=6000000 partial='false' bytes=8            ***     38.98 %       ±1.00%  ±1.34%  ±1.75%
10:33:07 buffers/buffer-copy.js n=6000000 partial='true' bytes=0                     -0.44 %       ±0.81%  ±1.08%  ±1.41%
10:33:07 buffers/buffer-copy.js n=6000000 partial='true' bytes=128           ***    256.54 %       ±1.31%  ±1.75%  ±2.31%
10:33:07 buffers/buffer-copy.js n=6000000 partial='true' bytes=32768         ***     35.39 %      ±11.48% ±15.46% ±20.49%
10:33:07 buffers/buffer-copy.js n=6000000 partial='true' bytes=8             ***    249.26 %       ±1.67%  ±2.24%  ±2.95%

nodejs-github-bot added buffer Issues and PRs related to the buffer subsystem. needs-ci PRs that need a full CI run. labels Jul 28, 2024

ronag commented Jul 28, 2024

Copy link
Copy Markdown
Member Author

@tniessen @anonrig @nodejs/performance @nodejs/buffer

ronag force-pushed the buffer-copy branch 3 times, most recently from d525f28 to 509b66d Compare July 28, 2024 21:39
anonrig added author ready PRs that have at least one approval, no outstanding review comments, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels Jul 28, 2024
github-actions Bot added request-ci-failed An error occurred while starting CI via request-ci label, and manual interventon is needed. and removed request-ci Add this label to start a Jenkins CI on a PR. labels Jul 28, 2024

github-actions Bot commented Jul 28, 2024

Copy link
Copy Markdown
Contributor
Failed to start CI
- Validating Jenkins credentials
✔  Jenkins credentials valid
- Starting PR CI job
✘  Failed to start PR CI: 400 Bad Request
https://github.com/nodejs/node/actions/runs/10134974481

ronag force-pushed the buffer-copy branch 2 times, most recently from 147b14d to ce07761 Compare July 28, 2024 22:29
jakecastelli added request-ci Add this label to start a Jenkins CI on a PR. and removed request-ci-failed An error occurred while starting CI via request-ci label, and manual interventon is needed. labels Jul 29, 2024
github-actions Bot added request-ci-failed An error occurred while starting CI via request-ci label, and manual interventon is needed. and removed request-ci Add this label to start a Jenkins CI on a PR. labels Jul 29, 2024

github-actions Bot commented Jul 29, 2024

Copy link
Copy Markdown
Contributor
Failed to start CI
   ⚠  Something was pushed to the Pull Request branch since the last approving review.
   ℹ  request-ci label was added by a Collaborator after the last push event.
- Validating Jenkins credentials
✔  Jenkins credentials valid
- Starting PR CI job
✘  Failed to start PR CI: 400 Bad Request
https://github.com/nodejs/node/actions/runs/10137136972

targos mentioned this pull request Jul 29, 2024
Closed
targos added the request-ci Add this label to start a Jenkins CI on a PR. label Jul 29, 2024
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 29, 2024

nodejs-github-bot commented Jul 29, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/60694/

This comment was marked as resolved.

Sign in to view

This comment was marked as outdated.

Sign in to view
ronag force-pushed the buffer-copy branch 3 times, most recently from 68cc51b to 7328b6f Compare July 29, 2024 05:58

nodejs-github-bot commented Jul 31, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/60766/

lemire reviewed Jul 31, 2024
View reviewed changes
Comment thread src/node_buffer.cc

ronag commented Jul 31, 2024

Copy link
Copy Markdown
Member Author

@aduh95 ?

aduh95 commented Jul 31, 2024

Copy link
Copy Markdown
Contributor

@aduh95 ?

https://openjs-foundation.slack.com/archives/C03BJP63CH0/p1722428074301359

ronag commented Jul 31, 2024 •
edited
Loading

Copy link
Copy Markdown
Member Author

@aduh95 I can't follow that link. Why did you remove the commit-queue label?

nodejs-github-bot commented Jul 31, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/60775/

aduh95 commented Jul 31, 2024

Copy link
Copy Markdown
Contributor

Because of the Windows failure

ronag commented Jul 31, 2024

Copy link
Copy Markdown
Member Author

@aduh95 seems unrelated are there known issues with the windows do?

nodejs-github-bot commented Jul 31, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/60777/

nodejs-github-bot commented Jul 31, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/60778/

nodejs-github-bot commented Aug 1, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/60794/

nodejs-github-bot commented Aug 1, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/60798/

nodejs-github-bot commented Aug 1, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/60799/

nodejs-github-bot commented Aug 2, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/60819/

nodejs-github-bot commented Aug 2, 2024

Copy link
Copy Markdown
Collaborator

Landed in 76c8ba9

RafaelGSS mentioned this pull request Aug 19, 2024
Merged
dlarocque mentioned this pull request Aug 23, 2024
Closed
ronag mentioned this pull request Aug 29, 2024
Closed
ramidzkh mentioned this pull request Oct 2, 2024
Closed
avivkeller mentioned this pull request Oct 17, 2024
Open
ronag mentioned this pull request Oct 21, 2024
Closed
7 tasks

ChALkeR commented Sep 23, 2025

Copy link
Copy Markdown
Member

This likely caused #59985

ChALkeR mentioned this pull request Oct 26, 2025
Merged
Felipeness mentioned this pull request Mar 8, 2026
Closed
crawfordxx mentioned this pull request Mar 30, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

lemire lemire approved these changes
benjamingr benjamingr approved these changes
anonrig anonrig approved these changes
mcollina Awaiting requested review from mcollina
targos Awaiting requested review from targos

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. buffer Issues and PRs related to the buffer subsystem. needs-ci PRs that need a full CI run. notable-change PRs with changes that should be highlighted in changelogs.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

10 participants

Back | FazBrowse Home | New Git URL