FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

doc: remove unused imports from worker_threads.md by debbs061 · Pull Request #54147 · nodejs/node · GitHub

/ node Public

doc: remove unused imports from worker_threads.md - #54147

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
debbs061:unused-import
Jul 31, 2024
Merged

doc: remove unused imports from worker_threads.md#54147
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
debbs061:unused-import

Conversation

debbs061 commented Jul 31, 2024
edited
Loading

Copy link
Copy Markdown
Contributor

Remove unused imports from worker_threads.md.

  • Removed once import from node:events as it was not used in the code.
  • Removed isMainThread import from node:worker_threads as it was not used in the code.

nodejs-github-bot added doc Issues and PRs related to the documentations. worker Issues and PRs related to Worker support. labels Jul 31, 2024
aduh95 changed the title typings: remove unused imports from worker_threads.md doc: remove unused imports from worker_threads.md Jul 31, 2024

deokjinkim left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

@debbs061 Thank you for contribution. Could you change subsystem from typings to doc in commit title? You can force push with -f option.

aduh95 added the fast-track PRs that do not need to wait for 48 hours to land. label Jul 31, 2024

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @aduh95. Please 👍 to approve.

aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 31, 2024
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 31, 2024
nodejs-github-bot merged commit 7941b4b into nodejs:main Jul 31, 2024

Copy link
Copy Markdown
Collaborator

Landed in 7941b4b

targos pushed a commit that referenced this pull request Aug 14, 2024
PR-URL: #54147
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Deokjin Kim <deokjin81.kim@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
RafaelGSS mentioned this pull request Aug 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land. worker Issues and PRs related to Worker support.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants


Back | FazBrowse Home | New Git URL