FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

dotenv: fix env-file parsing by lubosmato · Pull Request #54158 · nodejs/node · GitHub

/ node Public

dotenv: fix env-file parsing - #54158

Closed
lubosmato wants to merge 1 commit into
nodejs:mainfrom
lubosmato:main
Closed

dotenv: fix env-file parsing#54158
lubosmato wants to merge 1 commit into
nodejs:mainfrom
lubosmato:main

Conversation

Copy link
Copy Markdown

This PR makes parsing of env-file identical to dotenv npm package. Solves #54134

nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Aug 1, 2024

anonrig left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

We recently moved away from std::regex due to several reasons. #52406

targos commented Aug 1, 2024

Copy link
Copy Markdown
Member

We also can't accept a fix without tests that validate it.

lubosmato marked this pull request as draft August 1, 2024 17:00
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants


Back | FazBrowse Home | New Git URL