src,tools: allow utf-8 in built-in js source code by bnoordhuis · Pull Request #5418 · nodejs/node · GitHub

#4007 (comment) for background.

The meat is in the first commit, the other two are minor efficiency tweaks.

R=@Fishrock123

whoot! LGTM

CI: https://ci.nodejs.org/job/node-test-pull-request/1746/

PR-URL: nodejs#5418 Reviewed-By: Trevor Norris <trev.norris@gmail.com>

PR-URL: #5418 Reviewed-By: Trevor Norris <trev.norris@gmail.com>

adding lts-watch

@trevnorris feel free to remove if this is not appropriate

SGTM for LTS

@bnoordhuis this is not landing cleanly onto v4.x

would you have time to backport it?

If @bnoordhuis doesn't have time I could take care of it some time next week.

@trevnorris I just got this to land cleanly, although we are getting some fun errors now

node.js:970



SyntaxError: Unexpected token ILLEGAL

Seems to happen right after landing the first commit 14df4dc

@thealphanerd ... on what platform(s)?

I can back-port it but I confess I still haven't gotten around to unpacking the development rig where I've set up v4.x. (We plan on breaking out some walls so I've left most of my gear in boxes.) I'll see if I can get around to it this week.

@bnoordhuis hows the walls? 😃

PR-URL: nodejs#5418 Reviewed-By: Trevor Norris <trev.norris@gmail.com>

@thealphanerd Sorry for the delay. Back-port in #6200; the commits applied cleanly for me, FWIW.

not a problem. It is possible that something landed in the last round of backports that fixed things

thanks!

PR-URL: #5418 Reviewed-By: Trevor Norris <trev.norris@gmail.com>

bnoordhuis added the build Issues and PRs related to build files or the CI. label Feb 24, 2016

bnoordhuis mentioned this pull request Feb 24, 2016

Refactor Timers #4007

Closed

bnoordhuis force-pushed the allow-utf8-in-builtins branch from 730d2c0 to 83773b0 Compare February 25, 2016 11:43

bnoordhuis added 3 commits February 25, 2016 13:21

src,tools: allow utf-8 in built-in js source code

cdc7e02

PR-URL: nodejs#5418 Reviewed-By: Trevor Norris <trev.norris@gmail.com>

src,tools: drop nul byte from built-in source code

96adbe9

PR-URL: nodejs#5418 Reviewed-By: Trevor Norris <trev.norris@gmail.com>

src,tools: remove null sentinel from source array

33e51fe

PR-URL: nodejs#5418 Reviewed-By: Trevor Norris <trev.norris@gmail.com>

bnoordhuis force-pushed the allow-utf8-in-builtins branch from 83773b0 to 33e51fe Compare February 25, 2016 12:24

bnoordhuis closed this Feb 25, 2016

bnoordhuis deleted the allow-utf8-in-builtins branch February 25, 2016 12:24

bnoordhuis merged commit 33e51fe into nodejs:master Feb 25, 2016

rvagg pushed a commit that referenced this pull request Feb 27, 2016

src,tools: allow utf-8 in built-in js source code

14df4dc

PR-URL: #5418 Reviewed-By: Trevor Norris <trev.norris@gmail.com>

rvagg pushed a commit that referenced this pull request Feb 27, 2016

src,tools: drop nul byte from built-in source code

8e46cdf

PR-URL: #5418 Reviewed-By: Trevor Norris <trev.norris@gmail.com>

rvagg pushed a commit that referenced this pull request Feb 27, 2016

src,tools: remove null sentinel from source array

58bda8f

PR-URL: #5418 Reviewed-By: Trevor Norris <trev.norris@gmail.com>

rvagg pushed a commit that referenced this pull request Feb 27, 2016

src,tools: allow utf-8 in built-in js source code

17d14f3

PR-URL: #5418 Reviewed-By: Trevor Norris <trev.norris@gmail.com>

rvagg pushed a commit that referenced this pull request Feb 27, 2016

src,tools: drop nul byte from built-in source code

03a5dab

PR-URL: #5418 Reviewed-By: Trevor Norris <trev.norris@gmail.com>

rvagg pushed a commit that referenced this pull request Feb 27, 2016

src,tools: remove null sentinel from source array

51db48f

PR-URL: #5418 Reviewed-By: Trevor Norris <trev.norris@gmail.com>

Fishrock123 mentioned this pull request Mar 1, 2016

Release proposal: v5.7.1 #5464

Merged

5 tasks

MylesBorins mentioned this pull request Mar 10, 2016

Audit commits not found on v4.x #5647

Closed

MylesBorins added the lts-watch-v4.x label Mar 10, 2016

bnoordhuis added a commit to bnoordhuis/io.js that referenced this pull request Apr 14, 2016

src,tools: allow utf-8 in built-in js source code

480add8

PR-URL: nodejs#5418 Reviewed-By: Trevor Norris <trev.norris@gmail.com>

bnoordhuis added a commit to bnoordhuis/io.js that referenced this pull request Apr 14, 2016

src,tools: drop nul byte from built-in source code

08ef1e9

PR-URL: nodejs#5418 Reviewed-By: Trevor Norris <trev.norris@gmail.com>

bnoordhuis added a commit to bnoordhuis/io.js that referenced this pull request Apr 14, 2016

src,tools: remove null sentinel from source array

3322b3f

PR-URL: nodejs#5418 Reviewed-By: Trevor Norris <trev.norris@gmail.com>

bnoordhuis mentioned this pull request Apr 14, 2016

src,tools: allow utf-8 in built-in js source code #6200

Closed

MylesBorins added dont-land-on-v4.x and removed lts-watch-v4.x labels Apr 14, 2016

MylesBorins pushed a commit that referenced this pull request Apr 14, 2016

src,tools: allow utf-8 in built-in js source code

78726a7

PR-URL: #5418 Reviewed-By: Trevor Norris <trev.norris@gmail.com>

MylesBorins pushed a commit that referenced this pull request Apr 14, 2016

src,tools: drop nul byte from built-in source code

db4bc97

PR-URL: #5418 Reviewed-By: Trevor Norris <trev.norris@gmail.com>

MylesBorins pushed a commit that referenced this pull request Apr 14, 2016

src,tools: remove null sentinel from source array

9200d18

PR-URL: #5418 Reviewed-By: Trevor Norris <trev.norris@gmail.com>

MylesBorins pushed a commit that referenced this pull request Apr 22, 2016

src,tools: allow utf-8 in built-in js source code

bc447e4

PR-URL: #5418 Reviewed-By: Trevor Norris <trev.norris@gmail.com>

MylesBorins pushed a commit that referenced this pull request Apr 22, 2016

src,tools: drop nul byte from built-in source code

1b8a48e

PR-URL: #5418 Reviewed-By: Trevor Norris <trev.norris@gmail.com>

MylesBorins pushed a commit that referenced this pull request Apr 22, 2016

src,tools: remove null sentinel from source array

39e6f46

PR-URL: #5418 Reviewed-By: Trevor Norris <trev.norris@gmail.com>

MylesBorins pushed a commit that referenced this pull request May 6, 2016

src,tools: allow utf-8 in built-in js source code

96167bf

PR-URL: #5418 Reviewed-By: Trevor Norris <trev.norris@gmail.com>

MylesBorins pushed a commit that referenced this pull request May 6, 2016

src,tools: drop nul byte from built-in source code

d14f6d4

PR-URL: #5418 Reviewed-By: Trevor Norris <trev.norris@gmail.com>

MylesBorins pushed a commit that referenced this pull request May 6, 2016

src,tools: remove null sentinel from source array

d57a4ef

PR-URL: #5418 Reviewed-By: Trevor Norris <trev.norris@gmail.com>

MylesBorins pushed a commit that referenced this pull request May 18, 2016

src,tools: allow utf-8 in built-in js source code

d7a3ea4

PR-URL: #5418 Reviewed-By: Trevor Norris <trev.norris@gmail.com>

MylesBorins pushed a commit that referenced this pull request May 18, 2016

src,tools: drop nul byte from built-in source code

8f18414

PR-URL: #5418 Reviewed-By: Trevor Norris <trev.norris@gmail.com>

MylesBorins pushed a commit that referenced this pull request May 18, 2016

src,tools: remove null sentinel from source array

e0eebf4

PR-URL: #5418 Reviewed-By: Trevor Norris <trev.norris@gmail.com>

MylesBorins mentioned this pull request May 18, 2016

v4.4.5 proposal #6824

Merged

Clemens-git76 mentioned this pull request Apr 16, 2024

[Snyk] Upgrade rollup from 2.75.6 to 4.13.0 Clemens-git76/node#4

Open

src,tools: allow utf-8 in built-in js source code by bnoordhuis · Pull Request #5418 · nodejs/node · GitHub

Uh oh!

Uh oh!

src,tools: allow utf-8 in built-in js source code - #5418

src,tools: allow utf-8 in built-in js source code#5418
bnoordhuis merged 3 commits into
nodejs:masterfrom
bnoordhuis:allow-utf8-in-builtins

bnoordhuis commented Feb 24, 2016

Uh oh!

trevnorris commented Feb 24, 2016

Uh oh!

bnoordhuis commented Feb 25, 2016

Uh oh!

MylesBorins commented Mar 10, 2016

Uh oh!

jasnell commented Mar 11, 2016

Uh oh!

MylesBorins commented Mar 17, 2016

Uh oh!

trevnorris commented Mar 17, 2016

Uh oh!

MylesBorins commented Mar 21, 2016

Uh oh!

jasnell commented Mar 21, 2016

Uh oh!

bnoordhuis commented Mar 31, 2016

Uh oh!

MylesBorins commented Apr 8, 2016

Uh oh!

bnoordhuis commented Apr 14, 2016

Uh oh!

MylesBorins commented Apr 14, 2016 •
edited
Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

src,tools: allow utf-8 in built-in js source code by bnoordhuis · Pull Request #5418 · nodejs/node · GitHub

Uh oh!

Uh oh!

src,tools: allow utf-8 in built-in js source code - #5418

src,tools: allow utf-8 in built-in js source code#5418bnoordhuis merged 3 commits intonodejs:masternodejs/node:masterfrom bnoordhuis:allow-utf8-in-builtinsbnoordhuis/io.js:allow-utf8-in-builtinsCopy head branch name to clipboard

Conversation

bnoordhuis commented Feb 24, 2016

Uh oh!

trevnorris commented Feb 24, 2016

Uh oh!

bnoordhuis commented Feb 25, 2016

Uh oh!

MylesBorins commented Mar 10, 2016

Uh oh!

jasnell commented Mar 11, 2016

Uh oh!

MylesBorins commented Mar 17, 2016

Uh oh!

trevnorris commented Mar 17, 2016

Uh oh!

MylesBorins commented Mar 21, 2016

Uh oh!

jasnell commented Mar 21, 2016

Uh oh!

bnoordhuis commented Mar 31, 2016

Uh oh!

MylesBorins commented Apr 8, 2016

Uh oh!

bnoordhuis commented Apr 14, 2016

Uh oh!

MylesBorins commented Apr 14, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

src,tools: allow utf-8 in built-in js source code#5418
bnoordhuis merged 3 commits into
nodejs:masterfrom
bnoordhuis:allow-utf8-in-builtins

MylesBorins commented Apr 14, 2016 •
edited
Loading