doc: update buffer.constants.MAX_LENGTH size - #54207
Merged
nodejs-github-bot merged 1 commit intoAug 9, 2024
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Starting from Node v22.0.0 the `buffer.constants.MAX_LENGTH` has been increased from 4 GiB to 8 PiB due to V8 engine update to 12.4.254.14.
samuliasmala
force-pushed
the
doc-update-buffer-max-length
branch
from
7c5af98 to
5b72f63
Compare
August 5, 2024 05:32
Copy link
Copy Markdown
Contributor
Author
|
Updated the commit message to adhere 72 characters per line limit. |
Sorry, something went wrong.
jakecastelli
approved these changes
Aug 6, 2024
trivikr
approved these changes
Aug 9, 2024
lpinca
approved these changes
Aug 9, 2024
targos
pushed a commit
that referenced
this pull request
Aug 14, 2024
Starting from Node v22.0.0 the `buffer.constants.MAX_LENGTH` has been increased from 4 GiB to 8 PiB due to V8 engine update to 12.4.254.14. PR-URL: #54207 Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Merged
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Starting from Node v22.0.0 (which uses V8 12.4) the buffer.constants.MAX_LENGTH has been increased from 4 GiB to 8 PiB due to V8 engine update to 12.4.254.14. If I read it right the change was done in this commit to V8 engine.
The change is also easy to verify manually:
Welcome to Node.js v21.7.3. Type ".help" for more information. > (require('buffer').constants.MAX_LENGTH) / 2**30 4 Welcome to Node.js v22.0.0. Type ".help" for more information. > (require('buffer').constants.MAX_LENGTH + 1) / 2**30 8388608 > (require('buffer').constants.MAX_LENGTH + 1) / 2**40 8192 >