module: do not attempt to strip type when there's no source - #54287
Merged
nodejs-github-bot merged 1 commit intoAug 12, 2024
Merged
module: do not attempt to strip type when there's no source#54287nodejs-github-bot merged 1 commit into
nodejs-github-bot merged 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
|
Review requested:
|
Sorry, something went wrong.
marco-ippolito
approved these changes
Aug 9, 2024
VoltrexKeyva
approved these changes
Aug 9, 2024
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
benjamingr
approved these changes
Aug 9, 2024
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
MoLow
approved these changes
Aug 10, 2024
anonrig
approved these changes
Aug 10, 2024
jasnell
approved these changes
Aug 11, 2024
Copy link
Copy Markdown
Member
|
if #54250 lands we want to rethink this approach |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
I don't see why, it's still a win to avoid calling tsParse |
Sorry, something went wrong.
targos
pushed a commit
that referenced
this pull request
Aug 14, 2024
PR-URL: #54287 Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It bothers me that tsParse would return an empty string on non-string input, IMO it makes much more sense to use an assertion instead, and make sure the other parts of the code calling that function have already validated the input.