FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

src: update compile cache storage structure by joyeecheung · Pull Request #54291 · nodejs/node · GitHub

/ node Public

src: update compile cache storage structure - #54291

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
joyeecheung:refactor-compile-cache
Aug 19, 2024
ConversationCommits (1)ChecksFiles changed
Merged

src: update compile cache storage structure#54291
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
joyeecheung:refactor-compile-cache

Conversation

joyeecheung commented Aug 9, 2024 •
edited
Loading

Copy link
Copy Markdown
Member

This refactors the compile cache handler in preparation for the JS API, and updates the compile cache storage structure into:

- $NODE_COMPILE_CACHE_DIR
  - $NODE_VERION-$ARCH-$CACHE_DATA_VERSION_TAG-$UID
      - $FILENAME_AND_MODULE_TYPE_HASH.cache

This also adds a magic number to the beginning of the cache
files for verification, and returns the status, compile
cache directory and/or error message of enabling the
compile cache in a structure, which can be converted as
JS counterparts by the upcoming JS API.

Refs: #53639

joyeecheung added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 9, 2024
joyeecheung marked this pull request as ready for review August 9, 2024 19:30
nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Aug 9, 2024
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 9, 2024

nodejs-github-bot commented Aug 9, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/60994/

codecov Bot commented Aug 9, 2024 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 80.59701% with 13 lines in your changes missing coverage. Please review.

Project coverage is 87.08%. Comparing base (3cbeed8) to head (8f9eb07).
Report is 449 commits behind head on main.

Files with missing lines Patch % Lines
src/compile_cache.cc 81.81% 7 Missing and 1 partial ⚠️
src/env.cc 81.81% 2 Missing and 2 partials ⚠️
src/compile_cache.h 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #54291      +/-   ##
==========================================
- Coverage   87.11%   87.08%   -0.03%     
==========================================
  Files         647      647              
  Lines      181773   181965     +192     
  Branches    34889    34909      +20     
==========================================
+ Hits       158347   158470     +123     
- Misses      16739    16777      +38     
- Partials     6687     6718      +31
Files with missing lines Coverage Δ
src/env.h 97.87% <ø> (ø)
src/compile_cache.h 75.00% <0.00%> (-25.00%) ⬇️
src/env.cc 85.24% <81.81%> (-0.33%) ⬇️
src/compile_cache.cc 80.00% <81.81%> (-2.18%) ⬇️

... and 43 files with indirect coverage changes

joyeecheung commented Aug 9, 2024

Copy link
Copy Markdown
Member Author

cc @nodejs/startup @nodejs/cpp-reviewers

anonrig reviewed Aug 11, 2024
View reviewed changes

anonrig left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

We need more comments in this PR. It's extremely hard to keep track of the changes.

Comment thread src/compile_cache.cc Outdated
Comment thread src/compile_cache.h Outdated
src: update compile cache storage structure
8f9eb07 
This refactors the compile cache handler in preparation for the
JS API, and updates the compile cache storage structure into:

- $NODE_COMPILE_CACHE_DIR
  - $NODE_VERION-$ARCH-$CACHE_DATA_VERSION_TAG-$UID
    - $FILENAME_AND_MODULE_TYPE_HASH.cache

This also adds a magic number to the beginning of the cache
files for verification, and returns the status, compile
cache directory and/or error message of enabling the
compile cache in a structure, which can be converted as
JS counterparts by the upcoming JS API.
joyeecheung force-pushed the refactor-compile-cache branch from afb5bbc to 8f9eb07 Compare August 12, 2024 16:00

joyeecheung commented Aug 12, 2024

Copy link
Copy Markdown
Member Author

We need more comments in this PR. It's extremely hard to keep track of the changes.

FYI most of the changes here are preparation for https://github.com/joyeecheung/node/tree/compile-cache-api so I only sketched out what the changes are for in the commit messages, not in the comments.

joyeecheung added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 12, 2024
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 12, 2024

nodejs-github-bot commented Aug 12, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/61063/

nodejs-github-bot commented Aug 14, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/61104/

nodejs-github-bot commented Aug 14, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/61117/

nodejs-github-bot commented Aug 15, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/61121/

nodejs-github-bot commented Aug 15, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/61132/

joyeecheung added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 15, 2024
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 15, 2024

nodejs-github-bot commented Aug 15, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/61133/

joyeecheung added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 16, 2024
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 16, 2024

nodejs-github-bot commented Aug 16, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/61163/

joyeecheung added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 18, 2024
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 18, 2024

nodejs-github-bot commented Aug 18, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/61204/

nodejs-github-bot commented Aug 18, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/61211/

joyeecheung added the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 19, 2024
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 19, 2024
nodejs-github-bot merged commit b246f22 into nodejs:main Aug 19, 2024

nodejs-github-bot commented Aug 19, 2024

Copy link
Copy Markdown
Collaborator

Landed in b246f22

RafaelGSS pushed a commit that referenced this pull request Aug 19, 2024
src: update compile cache storage structure
1e3f772 
This refactors the compile cache handler in preparation for the
JS API, and updates the compile cache storage structure into:

- $NODE_COMPILE_CACHE_DIR
  - $NODE_VERION-$ARCH-$CACHE_DATA_VERSION_TAG-$UID
    - $FILENAME_AND_MODULE_TYPE_HASH.cache

This also adds a magic number to the beginning of the cache
files for verification, and returns the status, compile
cache directory and/or error message of enabling the
compile cache in a structure, which can be converted as
JS counterparts by the upcoming JS API.

PR-URL: #54291
Refs: #53639
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
RafaelGSS mentioned this pull request Aug 19, 2024
Merged
RafaelGSS pushed a commit that referenced this pull request Aug 21, 2024
src: update compile cache storage structure
e077ff1 
This refactors the compile cache handler in preparation for the
JS API, and updates the compile cache storage structure into:

- $NODE_COMPILE_CACHE_DIR
  - $NODE_VERION-$ARCH-$CACHE_DATA_VERSION_TAG-$UID
    - $FILENAME_AND_MODULE_TYPE_HASH.cache

This also adds a magic number to the beginning of the cache
files for verification, and returns the status, compile
cache directory and/or error message of enabling the
compile cache in a structure, which can be converted as
JS counterparts by the upcoming JS API.

PR-URL: #54291
Refs: #53639
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

anonrig anonrig left review comments
jasnell jasnell approved these changes
addaleax addaleax approved these changes
legendecas legendecas approved these changes
Ethan-Arrowood Ethan-Arrowood approved these changes

Assignees

No one assigned

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

Back | FazBrowse Home | New Git URL