repl: warn on assignment to _ - #5438
Closed
cjihrig wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
The REPL uses _ to store the result of the previous expression. This can cause confusion for REPL users who assign libraries like Underscore and Lodash to _. The documentation already mentions this behavior. This commit adds a printed warning if the user assigns to _.
Copy link
Copy Markdown
Member
|
How does this interact with #3737, is it one or the other? |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
@rvagg it looks like this subsumes #3737. I'm also seeing a few different behaviors, depending on the type of variable:
I think the varying behavior is related to #983. |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
Can't say I like this approach. I'd rather see something like #5431 (comment) |
Sorry, something went wrong.
4 tasks
This was referenced Oct 14, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request check-list
this change (including linting)?
test (or a benchmark) included?
existing APIs, or introduces new ones)?
Affected core subsystem(s)
repl
Description of change
The REPL uses _ to store the result of the previous expression. This can cause confusion for REPL users who assign libraries like Underscore and Lodash to _. The documentation already mentions this behavior. This commit adds a printed warning if the user assigns to _.
Refs: #5431