FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

[v22.x backport] doc: reserve ABI 130 for Electron 33 by clavin · Pull Request #54455 · nodejs/node · GitHub

/ node Public

[v22.x backport] doc: reserve ABI 130 for Electron 33 - #54455

Closed
clavin wants to merge 1 commit into
nodejs:v22.x-stagingfrom
clavin:clavin/doc-electron-33-abi-for-v22
ConversationCommits (1)ChecksFiles changed
Closed

[v22.x backport] doc: reserve ABI 130 for Electron 33#54455
clavin wants to merge 1 commit into
nodejs:v22.x-stagingfrom
clavin:clavin/doc-electron-33-abi-for-v22

Conversation

clavin commented Aug 19, 2024

Copy link
Copy Markdown
Contributor

Manual backport of #54383 to v22.x.

nodejs-github-bot added doc Issues and PRs related to the documentations. v22.x Issues that can be reproduced on v22.x or PRs targeting the v22.x-staging branch. labels Aug 19, 2024
clavin mentioned this pull request Aug 19, 2024
Merged

avivkeller commented Aug 19, 2024

Copy link
Copy Markdown
Member

I'm not sure whether the branch to target should be v22.x or v22.x-staging

clavin commented Aug 19, 2024

Copy link
Copy Markdown
Contributor Author

Found some docs about it and it looks like I need to potentially reformat my commit & indeed target v22.x-staging. Thanks for the note! I'll do that shortly.

clavin force-pushed the clavin/doc-electron-33-abi-for-v22 branch from 26ab808 to a574bd5 Compare August 19, 2024 16:02
clavin changed the base branch from v22.x to v22.x-staging August 19, 2024 16:03
clavin changed the title doc: reserve ABI 130 for Electron 33 [v22.x backport] doc: reserve ABI 130 for Electron 33 Aug 19, 2024
clavin force-pushed the clavin/doc-electron-33-abi-for-v22 branch from a574bd5 to 2013511 Compare August 19, 2024 16:04

clavin commented Aug 19, 2024

Copy link
Copy Markdown
Contributor Author

👍 Alright, everything seems to be formatted properly now. I added the Backport-PR-URL: metadata to the backport commit here as well. (I assume it's supposed to point to this PR, but lmk if it should be something else!)

doc: reserve ABI 130 for Electron 33
a319641 
Backport-PR-URL: nodejs#54455
PR-URL: nodejs#54383
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
clavin force-pushed the clavin/doc-electron-33-abi-for-v22 branch from 2013511 to a319641 Compare August 22, 2024 19:29

clavin commented Aug 22, 2024

Copy link
Copy Markdown
Contributor Author

v22.x-staging got force-pushed to a new commit, so I rebased this PR to resolve the commit diffs.

RafaelGSS pushed a commit that referenced this pull request Aug 24, 2024
doc: reserve ABI 130 for Electron 33
83b5efe 
Backport-PR-URL: #54455
PR-URL: #54383
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>

RafaelGSS commented Aug 24, 2024

Copy link
Copy Markdown
Member

Landed in 83b5efe

RafaelGSS closed this Aug 24, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

RafaelGSS RafaelGSS approved these changes

Assignees

No one assigned

Labels

doc Issues and PRs related to the documentations. v22.x Issues that can be reproduced on v22.x or PRs targeting the v22.x-staging branch.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL