FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

deps: update amaro to 0.1.7 by nodejs-github-bot · Pull Request #54473 · nodejs/node · GitHub

/ node Public

deps: update amaro to 0.1.7 - #54473

Merged
nodejs-github-bot merged 1 commit into
mainfrom
actions/tools-update-amaro
Aug 23, 2024
Merged

deps: update amaro to 0.1.7#54473
nodejs-github-bot merged 1 commit into
mainfrom
actions/tools-update-amaro

Conversation

Copy link
Copy Markdown
Collaborator

This is an automated update of amaro to 0.1.7.

nodejs-github-bot added the dependencies Pull requests that update a dependency file. label Aug 21, 2024

Copy link
Copy Markdown
Collaborator Author

Review requested:

  • @nodejs/security-wg
  • @nodejs/typescript

nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. strip-types Issues or PRs related to strip-types support labels Aug 21, 2024

marco-ippolito left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

missing swc license 🫤

kdy1 commented Aug 21, 2024

Copy link
Copy Markdown
Member

Is it a problem of the SWC package?

marco-ippolito dismissed their stale review August 21, 2024 07:20

NEVER MIND we already added that in a previous release

Copy link
Copy Markdown
Member

Is it a problem of the SWC package?

nono we already added and I forgot 😆 all good

codecov Bot commented Aug 21, 2024
edited
Loading

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.29%. Comparing base (821ffab) to head (05f328e).
Report is 334 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #54473      +/-   ##
==========================================
- Coverage   87.31%   87.29%   -0.03%     
==========================================
  Files         648      648              
  Lines      182365   182365              
  Branches    34988    34977      -11     
==========================================
- Hits       159236   159194      -42     
- Misses      16393    16446      +53     
+ Partials     6736     6725      -11     

see 29 files with indirect coverage changes

marco-ippolito added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 21, 2024
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 21, 2024

Copy link
Copy Markdown
Collaborator Author

Copy link
Copy Markdown
Collaborator Author

aduh95 added author ready PRs that have at least one approval, no outstanding review comments, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Aug 22, 2024
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 23, 2024
nodejs-github-bot merged commit d787144 into main Aug 23, 2024

Copy link
Copy Markdown
Collaborator Author

Landed in d787144

nodejs-github-bot deleted the actions/tools-update-amaro branch August 23, 2024 07:23
RafaelGSS pushed a commit that referenced this pull request Aug 25, 2024
PR-URL: #54473
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
RafaelGSS mentioned this pull request Aug 25, 2024
RafaelGSS pushed a commit that referenced this pull request Aug 30, 2024
PR-URL: #54473
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. dependencies Pull requests that update a dependency file. needs-ci PRs that need a full CI run. strip-types Issues or PRs related to strip-types support

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants


Back | FazBrowse Home | New Git URL