tls: wrap ssl errors in ECONNRESET - #54492
Closed
Uzlopak wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Merged
Copy link
Copy Markdown
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #54492 +/- ##
==========================================
+ Coverage 87.31% 87.33% +0.01%
==========================================
Files 648 649 +1
Lines 182359 182530 +171
Branches 34979 35028 +49
==========================================
+ Hits 159235 159411 +176
+ Misses 16389 16381 -8
- Partials 6735 6738 +3
... and 37 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
This pull request has been marked as stale due to 90 days of inactivity. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For discussion.
I think we should not break userland, by passing the OpenSSL Errors directly to userland. IMHO they need to be wrapped accordingly.
This PR is not passing all tests and is for demonstration purposes.
Especially notifying:
@mcollina
@RafaelGSS
@nodejs/undici