FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

deps: update amaro to 0.1.8 by nodejs-github-bot · Pull Request #54520 · nodejs/node · GitHub

/ node Public

deps: update amaro to 0.1.8 - #54520

Merged
nodejs-github-bot merged 1 commit into
mainfrom
actions/tools-update-amaro
Aug 25, 2024
ConversationCommits (1)ChecksFiles changed
Merged

deps: update amaro to 0.1.8#54520
nodejs-github-bot merged 1 commit into
mainfrom
actions/tools-update-amaro

Conversation

nodejs-github-bot commented Aug 23, 2024

Copy link
Copy Markdown
Collaborator

This is an automated update of amaro to 0.1.8.

nodejs-github-bot added dependencies Pull requests that update a dependency file. strip-types Issues or PRs related to strip-types support labels Aug 23, 2024

nodejs-github-bot commented Aug 23, 2024

Copy link
Copy Markdown
Collaborator Author

Review requested:

  • @nodejs/security-wg
  • @nodejs/typescript

nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Aug 23, 2024

marco-ippolito commented Aug 23, 2024

Copy link
Copy Markdown
Member

this update, adds the correct default configuration https://github.com/nodejs/node/pull/54520/files#diff-2eb38b7205bf0f3655deb5fd6ce17d625dce1cfe78d204d16c89a67f35c146e6R492-R499

marco-ippolito mentioned this pull request Aug 23, 2024
Closed
marco-ippolito added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 23, 2024
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 23, 2024

nodejs-github-bot commented Aug 23, 2024

Copy link
Copy Markdown
Collaborator Author

CI: https://ci.nodejs.org/job/node-test-pull-request/61370/

marco-ippolito added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Aug 23, 2024

codecov Bot commented Aug 23, 2024 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.34%. Comparing base (628469c) to head (abef85f).
Report is 318 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #54520   +/-   ##
=======================================
  Coverage   87.34%   87.34%           
=======================================
  Files         649      649           
  Lines      182576   182576           
  Branches    35036    35041    +5     
=======================================
+ Hits       159467   159471    +4     
+ Misses      16381    16379    -2     
+ Partials     6728     6726    -2

see 32 files with indirect coverage changes

nodejs-github-bot commented Aug 23, 2024

Copy link
Copy Markdown
Collaborator Author

CI: https://ci.nodejs.org/job/node-test-pull-request/61371/

marco-ippolito added the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 24, 2024
marco-ippolito mentioned this pull request Aug 24, 2024
Closed

ovflowd commented Aug 24, 2024

Copy link
Copy Markdown
Member

@marco-ippolito do you feel like fast-tracking this PR is necessary?

marco-ippolito commented Aug 24, 2024

Copy link
Copy Markdown
Member

@marco-ippolito do you feel like fast-tracking this PR is necessary?

Its ok Ivr added commit queue

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 25, 2024
nodejs-github-bot merged commit c3fe2d6 into main Aug 25, 2024

nodejs-github-bot commented Aug 25, 2024

Copy link
Copy Markdown
Collaborator Author

Landed in c3fe2d6

nodejs-github-bot deleted the actions/tools-update-amaro branch August 25, 2024 10:12
RafaelGSS pushed a commit that referenced this pull request Aug 30, 2024
deps: update amaro to 0.1.8
290f6ce 
PR-URL: #54520
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Claudio Wunder <cwunder@gnome.org>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
RafaelGSS mentioned this pull request Aug 30, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

benjamingr benjamingr approved these changes
ovflowd ovflowd approved these changes
RafaelGSS RafaelGSS approved these changes
marco-ippolito marco-ippolito approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. dependencies Pull requests that update a dependency file. needs-ci PRs that need a full CI run. strip-types Issues or PRs related to strip-types support

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL