buffer: don't use Fast API for utf8 - #54525
Closed
ronag wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Fast API handles invalid UTF differently than the slow API. Fixes: nodejs#54521 PR-URL: nodejs#54525
Copy link
Copy Markdown
Member
Author
|
Would be nice if we could have a fast implementation that does the same as WriteUtf8Impl in V8. |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
#54526 Seems like a better option. |
Sorry, something went wrong.
Copy link
Copy Markdown
Codecov ReportAll modified and coverable lines are covered by tests ✅ Additional details and impacted files @@ Coverage Diff @@
## main #54525 +/- ##
==========================================
- Coverage 87.33% 87.32% -0.01%
==========================================
Files 649 649
Lines 182561 182559 -2
Branches 35041 35040 -1
==========================================
- Hits 159444 159424 -20
- Misses 16378 16394 +16
- Partials 6739 6741 +2
|
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fast API handles invalid UTF differently than the slow API.
Fixes: #54521