src: add unistd.h import if node posix credentials is defined - #54528
Merged
nodejs-github-bot merged 1 commit intoSep 20, 2024
Merged
src: add unistd.h import if node posix credentials is defined#54528nodejs-github-bot merged 1 commit into
nodejs-github-bot merged 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
JonasBa
force-pushed
the
jb/darwin-compile
branch
from
a362cca to
1f2f13d
Compare
August 23, 2024 20:29
Copy link
Copy Markdown
Codecov ReportAll modified and coverable lines are covered by tests ✅ Additional details and impacted files @@ Coverage Diff @@
## main #54528 +/- ##
==========================================
- Coverage 88.04% 88.03% -0.01%
==========================================
Files 652 652
Lines 183764 183764
Branches 35862 35862
==========================================
- Hits 161787 161782 -5
- Misses 15233 15236 +3
- Partials 6744 6746 +2
|
Sorry, something went wrong.
anonrig
approved these changes
Aug 23, 2024
This comment was marked as outdated.
This comment was marked as outdated.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
addaleax
approved these changes
Aug 24, 2024
Copy link
Copy Markdown
Contributor
|
Typo in commit message, unitsd.h -> unistd.h. |
Sorry, something went wrong.
jasnell
approved these changes
Aug 25, 2024
Copy link
Copy Markdown
Member
|
PR is currently blocked from landing due to unreliable CI. Likely needs a rebase |
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
JonasBa
force-pushed
the
jb/darwin-compile
branch
from
1f2f13d to
fc8de8f
Compare
September 19, 2024 21:35
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
I've rebased the PR, should be good to merge now, thank you @jasnell and sorry for the delay, I was on vacation! |
Sorry, something went wrong.
richardlau
approved these changes
Sep 20, 2024
targos
pushed a commit
that referenced
this pull request
Oct 4, 2024
usage comment PR-URL: #54528 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #54519