FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test: use test runner in `test-report-config` by avivkeller · Pull Request #54571 · nodejs/node · GitHub

/ node Public

test: use test runner in test-report-config - #54571

Closed
avivkeller wants to merge 1 commit into
nodejs:mainfrom
avivkeller:patch-111
ConversationCommits (1)ChecksFiles changed
Closed

test: use test runner in test-report-config#54571
avivkeller wants to merge 1 commit into
nodejs:mainfrom
avivkeller:patch-111

Conversation

avivkeller commented Aug 26, 2024

Copy link
Copy Markdown
Member 
NOTE: The test started as a child_process using these flags: [
  '--report-on-fatalerror',
  '--report-on-signal',
  '--report-uncaught-exception',
  '--report-compact'
] Use NODE_SKIP_FLAG_CHECK to run the test with the original flags.
✔ Verify that the interaction between reportOnSignal and signal is correct. (1.468327ms)
✔ Verify that process.report.directory behaves properly (0.918158ms)
✔ Verify that process.report.filename behaves properly (0.20325ms)
✔ Verify that process.report.reportOnFatalError behaves properly (0.151694ms)
✔ Verify that process.report.reportOnUncaughtException behaves properly (0.275656ms)
✔ Verify that process.report.reportOnSignal behaves properly (0.164718ms)
✔ Verify that process.report.compact behaves properly (0.184926ms)
✔ Verify that process.report.excludeNetwork behaves properly (0.187271ms)
✔ Verify that process.report.signal behaves properly (0.750093ms)
ℹ tests 9
ℹ suites 0
ℹ pass 9
ℹ fail 0
ℹ cancelled 0
ℹ skipped 0
ℹ todo 0
ℹ duration_ms 11.282749

nodejs-github-bot added needs-ci PRs that need a full CI run. report Issues and PRs related to process.report. test Issues and PRs related to the tests. labels Aug 26, 2024

codecov Bot commented Aug 26, 2024 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.30%. Comparing base (4f1c27a) to head (1e749ca).
Report is 139 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #54571      +/-   ##
==========================================
- Coverage   87.33%   87.30%   -0.03%     
==========================================
  Files         649      649              
  Lines      182620   182755     +135     
  Branches    35042    35046       +4     
==========================================
+ Hits       159490   159560      +70     
- Misses      16394    16462      +68     
+ Partials     6736     6733       -3

see 64 files with indirect coverage changes

targos commented Aug 27, 2024

Copy link
Copy Markdown
Member

We should find a better way to describe the changes if these refactorings become recurrent, because this is not using the test runner (which whould be node --test)

cjihrig commented Aug 28, 2024

Copy link
Copy Markdown
Contributor

Maybe say "node:test" instead of test runner as done in #54585 and similar PRs.

atlowChemi added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 29, 2024
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 29, 2024

nodejs-github-bot commented Aug 29, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/61635/

avivkeller commented Aug 29, 2024

Copy link
Copy Markdown
Member Author

commit message updated :-)

cjihrig added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 30, 2024
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 30, 2024

nodejs-github-bot commented Aug 30, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/61705/

avivkeller commented Sep 7, 2024

Copy link
Copy Markdown
Member Author

CI is not passing. @jasnell and @anonrig appear to already be covering this base, so I'll close this.

avivkeller closed this Sep 7, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jasnell jasnell approved these changes
cjihrig cjihrig approved these changes

Assignees

No one assigned

Labels

needs-ci PRs that need a full CI run. report Issues and PRs related to process.report. test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL