(vee-eight-4.9) src: update uses of deprecated NewExternal - #5462
Closed
ofrobots wants to merge 1 commit into
Closed
(vee-eight-4.9) src: update uses of deprecated NewExternal#5462ofrobots wants to merge 1 commit into
ofrobots wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
V8 String::NewExternal is deprecated in 4.9. Migrate string_bytes.cc to the alternatives.
Copy link
Copy Markdown
Member
Sorry, something went wrong.
ofrobots
added a commit
that referenced
this pull request
Feb 29, 2016
V8 String::NewExternal is deprecated in 4.9. Migrate string_bytes.cc to the alternatives. PR-URL: #5462 Reviewed-By: bnoordhuis - Ben Noordhuis <info@bnoordhuis.nl>
Copy link
Copy Markdown
Contributor
Author
|
Thanks. Landed on vee-eight-4.9 as fee485e (after a second CI: https://ci.nodejs.org/job/node-test-pull-request/1778/.) |
Sorry, something went wrong.
ofrobots
added a commit
to ofrobots/node
that referenced
this pull request
Mar 1, 2016
V8 String::NewExternal is deprecated in 4.9. Migrate string_bytes.cc to the alternatives. PR-URL: nodejs#5462 Reviewed-By: bnoordhuis - Ben Noordhuis <info@bnoordhuis.nl>
ofrobots
added a commit
to ofrobots/node
that referenced
this pull request
Mar 3, 2016
V8 String::NewExternal is deprecated in 4.9. Migrate string_bytes.cc to the alternatives. PR-URL: nodejs#5462 Reviewed-By: bnoordhuis - Ben Noordhuis <info@bnoordhuis.nl>
ofrobots
added a commit
that referenced
this pull request
Mar 4, 2016
V8 String::NewExternal is deprecated in 4.9. Migrate string_bytes.cc to the alternatives. PR-URL: #5462 Reviewed-By: bnoordhuis - Ben Noordhuis <info@bnoordhuis.nl>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request check-list
this change (including linting)?
test (or a benchmark) included?
existing APIs, or introduces new ones)?
Affected core subsystem(s)
src (string_bytes)
Description of change
V8 String::NewExternal is deprecated in 4.9. Migrate string_bytes.cc to
the alternatives.
R=@bnoordhuis @nodejs/v8
Ref: #5392, #5204, #4869