doc: fix module compile cache description - #54625
Merged
nodejs-github-bot merged 1 commit intoAug 29, 2024
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
|
Review requested:
|
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
@joyeecheung There is a mistake in the document. About this PR (#54501) |
Sorry, something went wrong.
joyeecheung
approved these changes
Aug 29, 2024
joyeecheung
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Thanks for catching it!
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
Fast-track has been requested by @joyeecheung. Please 👍 to approve. |
Sorry, something went wrong.
aduh95
approved these changes
Aug 29, 2024
RafaelGSS
pushed a commit
that referenced
this pull request
Aug 30, 2024
PR-URL: #54625 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix the wrong environment variables in the module compile cache documentation