FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

deps: patch V8 to 12.8.374.31 by targos · Pull Request #54682 · nodejs/node · GitHub

/ node Public

deps: patch V8 to 12.8.374.31 - #54682

Closed
targos wants to merge 2 commits into
nodejs:mainfrom
targos:v8-patch
Closed

deps: patch V8 to 12.8.374.31#54682
targos wants to merge 2 commits into
nodejs:mainfrom
targos:v8-patch

Conversation

targos commented Sep 1, 2024
edited
Loading

Copy link
Copy Markdown
Member
  • Revert "deps: remove bogus V8 DCHECK"
  • deps: patch V8 to 12.8.374.31

Refs: v8/v8@12.8.374.22...12.8.374.31

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/gyp
  • @nodejs/security-wg
  • @nodejs/v8-update

nodejs-github-bot added build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. v8 engine Issues and PRs related to the V8 dependency. labels Sep 1, 2024
targos added dont-land-on-v18.x dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. and removed build Issues and PRs related to build files or the CI. v8 engine Issues and PRs related to the V8 dependency. needs-ci PRs that need a full CI run. labels Sep 1, 2024
aduh95 added build Issues and PRs related to build files or the CI. v8 engine Issues and PRs related to the V8 dependency. author ready PRs that have at least one approval, no outstanding review comments, and a CI started. needs-ci PRs that need a full CI run. request-ci Add this label to start a Jenkins CI on a PR. labels Sep 3, 2024

This comment was marked as outdated.

This comment was marked as outdated.

github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 3, 2024

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

richardlau added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 4, 2024
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 4, 2024

This comment was marked as outdated.

This comment was marked as outdated.

jasnell commented Sep 8, 2024

Copy link
Copy Markdown
Member

PR is currently blocked from landing due to unreliable CI

This comment was marked as outdated.

targos added the commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. label Sep 9, 2024
targos changed the title deps: patch V8 to 12.8.374.26 deps: patch V8 to 12.8.374.31 Sep 9, 2024

targos commented Sep 9, 2024

Copy link
Copy Markdown
Member Author

Rebased and updated.

targos added request-ci Add this label to start a Jenkins CI on a PR. and removed request-ci Add this label to start a Jenkins CI on a PR. labels Sep 9, 2024

Copy link
Copy Markdown
Collaborator

Copy link
Copy Markdown
Collaborator

Copy link
Copy Markdown
Collaborator

Copy link
Copy Markdown
Collaborator

Copy link
Copy Markdown
Collaborator

Copy link
Copy Markdown
Collaborator

targos added the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 11, 2024
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 11, 2024

Copy link
Copy Markdown
Collaborator

Landed in 123bb4c...9087056

nodejs-github-bot pushed a commit that referenced this pull request Sep 11, 2024
This reverts commit fba06eb.

PR-URL: #54682
Refs: v8/v8@12.8.374.22...12.8.374.31
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
nodejs-github-bot pushed a commit that referenced this pull request Sep 11, 2024
Refs: v8/v8@12.8.374.22...12.8.374.31
PR-URL: #54682
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos deleted the v8-patch branch September 11, 2024 07:19
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. build Issues and PRs related to build files or the CI. commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. needs-ci PRs that need a full CI run. v8 engine Issues and PRs related to the V8 dependency.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants


Back | FazBrowse Home | New Git URL