FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

zlib: remove prototype primordials usage by anonrig · Pull Request #54695 · nodejs/node · GitHub

/ node Public

zlib: remove prototype primordials usage - #54695

Merged
nodejs-github-bot merged 2 commits into
nodejs:mainfrom
anonrig:yagiz/remove-primordials-zlib
Sep 19, 2024
ConversationCommits (2)ChecksFiles changed
Merged

zlib: remove prototype primordials usage#54695
nodejs-github-bot merged 2 commits into
nodejs:mainfrom
anonrig:yagiz/remove-primordials-zlib

Conversation

anonrig commented Sep 1, 2024

Copy link
Copy Markdown
Member

As a result of the primordials work done by @aduh95 and others, let's remove the prototypal primordials from node:zlib

anonrig requested a review from aduh95 September 1, 2024 16:28

nodejs-github-bot commented Sep 1, 2024

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/tsc

nodejs-github-bot added needs-ci PRs that need a full CI run. zlib Issues and PRs related to the zlib subsystem. labels Sep 1, 2024

avivkeller commented Sep 1, 2024

Copy link
Copy Markdown
Member

CC @nodejs/primordials @nodejs/zlib

avivkeller added the needs-benchmark-ci PR that need a benchmark CI run. label Sep 1, 2024
anonrig added author ready PRs that have at least one approval, no outstanding review comments, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Sep 1, 2024
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 1, 2024

This comment was marked as outdated.

Sign in to view
aduh95 reviewed Sep 1, 2024
View reviewed changes
Comment thread lib/zlib.js Outdated
anonrig added the commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. label Sep 1, 2024

codecov Bot commented Sep 1, 2024 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.07%. Comparing base (c77bcf0) to head (3bf4e0a).
Report is 520 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #54695      +/-   ##
==========================================
- Coverage   88.07%   88.07%   -0.01%     
==========================================
  Files         652      652              
  Lines      183570   183566       -4     
  Branches    35872    35860      -12     
==========================================
- Hits       161686   161681       -5     
- Misses      15137    15140       +3     
+ Partials     6747     6745       -2
Files with missing lines Coverage Δ
lib/zlib.js 98.41% <100.00%> (-0.01%) ⬇️

... and 41 files with indirect coverage changes

This comment was marked as outdated.

Sign in to view
ljharb reviewed Sep 1, 2024
View reviewed changes
Comment thread lib/zlib.js Outdated
Comment thread lib/zlib.js Outdated
Comment thread doc/contributing/primordials.md Outdated

This comment was marked as outdated.

Sign in to view

This comment was marked as outdated.

Sign in to view

This comment was marked as outdated.

Sign in to view

jasnell commented Sep 8, 2024

Copy link
Copy Markdown
Member

This PR is currently blocked from landing due to unreliable CI

aduh95 added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 9, 2024
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 9, 2024

nodejs-github-bot commented Sep 9, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/62225/

anonrig force-pushed the yagiz/remove-primordials-zlib branch from 61cd7b9 to a77b6cb Compare September 10, 2024 15:01
anonrig requested a review from jasnell September 10, 2024 23:52

nodejs-github-bot commented Sep 10, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/62293/

nodejs-github-bot commented Sep 11, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/62298/

anonrig and others added 2 commits September 15, 2024 16:06
zlib: remove prototype primordials usage
3e6daa1 
# Conflicts:
#	lib/zlib.js
Update zlib.js
3bf4e0a 
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
anonrig force-pushed the yagiz/remove-primordials-zlib branch from a77b6cb to 3bf4e0a Compare September 15, 2024 20:06

nodejs-github-bot commented Sep 15, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/62464/

nodejs-github-bot commented Sep 18, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/62543/

anonrig added the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 19, 2024
nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Sep 19, 2024

nodejs-github-bot commented Sep 19, 2024

Copy link
Copy Markdown
Collaborator
Commit Queue failed
- Loading data for nodejs/node/pull/54695
✔  Done loading data for nodejs/node/pull/54695
----------------------------------- PR info ------------------------------------
Title      zlib: remove prototype primordials usage (#54695)
Author     Yagiz Nizipli <yagiz@nizipli.com> (@anonrig)
Branch     anonrig:yagiz/remove-primordials-zlib -> nodejs:main
Labels     zlib, author ready, needs-ci, needs-benchmark-ci, commit-queue-squash
Commits    2
 - zlib: remove prototype primordials usage
 - Update zlib.js
Committers 1
 - Yagiz Nizipli <yagiz@nizipli.com>
PR-URL: https://github.com/nodejs/node/pull/54695
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruy Adorno <ruy@vlt.sh>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/54695
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruy Adorno <ruy@vlt.sh>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
--------------------------------------------------------------------------------
   ⚠  Commits were pushed since the last approving review:
   ⚠  - zlib: remove prototype primordials usage
   ⚠  - Update zlib.js
   ℹ  This PR was created on Sun, 01 Sep 2024 16:28:21 GMT
   ✔  Approvals: 7
   ✔  - Michaël Zasso (@targos) (TSC): https://github.com/nodejs/node/pull/54695#pullrequestreview-2274458346
   ✔  - Marco Ippolito (@marco-ippolito) (TSC): https://github.com/nodejs/node/pull/54695#pullrequestreview-2274459245
   ✔  - Robert Nagy (@ronag) (TSC): https://github.com/nodejs/node/pull/54695#pullrequestreview-2277737863
   ✔  - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/54695#pullrequestreview-2277787527
   ✔  - Ruy Adorno (@ruyadorno) (TSC): https://github.com/nodejs/node/pull/54695#pullrequestreview-2283877520
   ✔  - Moshe Atlow (@MoLow) (TSC): https://github.com/nodejs/node/pull/54695#pullrequestreview-2289797393
   ✔  - Trivikram Kamat (@trivikr): https://github.com/nodejs/node/pull/54695#pullrequestreview-2295411895
   ✔  Last GitHub CI successful
   ℹ  Last Full PR CI on 2024-09-18T23:57:25Z: https://ci.nodejs.org/job/node-test-pull-request/62543/
- Querying data for job/node-test-pull-request/62543/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/10933395608

anonrig requested a review from KhafraDev September 19, 2024 02:38
anonrig added commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Sep 19, 2024
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 19, 2024
nodejs-github-bot merged commit c42d846 into nodejs:main Sep 19, 2024

nodejs-github-bot commented Sep 19, 2024

Copy link
Copy Markdown
Collaborator

Landed in c42d846

targos pushed a commit that referenced this pull request Oct 4, 2024
zlib: remove prototype primordials usage
9abd1c7 
# Conflicts:
#	lib/zlib.js

PR-URL: #54695
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruy Adorno <ruy@vlt.sh>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>
aduh95 mentioned this pull request Oct 9, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

ljharb ljharb left review comments
aduh95 aduh95 left review comments
ruyadorno ruyadorno approved these changes
ronag ronag approved these changes
MoLow MoLow approved these changes
trivikr trivikr approved these changes
marco-ippolito marco-ippolito approved these changes
KhafraDev KhafraDev approved these changes
jasnell Awaiting requested review from jasnell
+1 more reviewer
targos targos approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. needs-benchmark-ci PR that need a benchmark CI run. needs-ci PRs that need a full CI run. zlib Issues and PRs related to the zlib subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Back | FazBrowse Home | New Git URL