FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

lib,src: use built-in array buffer detach, transfer by anonrig · Pull Request #54837 · nodejs/node · GitHub

/ node Public

lib,src: use built-in array buffer detach, transfer - #54837

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
anonrig:yagiz/use-array-buffer-transfer
Sep 16, 2024
ConversationCommits (1)ChecksFiles changed
Merged

lib,src: use built-in array buffer detach, transfer#54837
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
anonrig:yagiz/use-array-buffer-transfer

Conversation

anonrig commented Sep 7, 2024

Copy link
Copy Markdown
Member

Following up on #50130

anonrig requested a review from legendecas September 7, 2024 17:38

nodejs-github-bot commented Sep 7, 2024

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/loaders

nodejs-github-bot added lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Sep 7, 2024
anonrig force-pushed the yagiz/use-array-buffer-transfer branch from 6723407 to b1e1e32 Compare September 7, 2024 19:02
legendecas reviewed Sep 7, 2024
View reviewed changes
Comment thread lib/internal/modules/esm/worker.js Outdated

codecov Bot commented Sep 7, 2024 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.89%. Comparing base (dcc2ed9) to head (ce678e1).
Report is 82 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #54837      +/-   ##
==========================================
+ Coverage   87.62%   87.89%   +0.26%     
==========================================
  Files         650      651       +1     
  Lines      182983   183299     +316     
  Branches    35406    35709     +303     
==========================================
+ Hits       160336   161105     +769     
+ Misses      15917    15472     -445     
+ Partials     6730     6722       -8
Files with missing lines Coverage Δ
lib/internal/util.js 96.82% <ø> (+0.06%) ⬆️
lib/internal/webstreams/readablestream.js 98.32% <100.00%> (-0.01%) ⬇️
lib/internal/webstreams/util.js 96.51% <ø> (+3.98%) ⬆️
src/node_util.cc 86.02% <ø> (+0.25%) ⬆️

... and 72 files with indirect coverage changes

anonrig force-pushed the yagiz/use-array-buffer-transfer branch from b1e1e32 to 6621617 Compare September 7, 2024 22:23
anonrig requested a review from legendecas September 7, 2024 22:24
anonrig force-pushed the yagiz/use-array-buffer-transfer branch from 6621617 to 2738f00 Compare September 8, 2024 14:58

anonrig commented Sep 8, 2024

Copy link
Copy Markdown
Member Author

@nodejs/primordials how do you add a primordial for an attribute? ArrayBufferPrototypeDetached is an attribute not a function. Ex: buffer.detached

ljharb commented Sep 8, 2024

Copy link
Copy Markdown
Member

It’s a getter function on the prototype - uncurryThis(Object.getOwnPropertyDescriptor(ArrayBuffer.prototype, 'detached').get) should do it.

anonrig force-pushed the yagiz/use-array-buffer-transfer branch from 2738f00 to cbe6bf7 Compare September 8, 2024 15:04

anonrig commented Sep 8, 2024

Copy link
Copy Markdown
Member Author

It’s a getter function on the prototype - uncurryThis(Object.getOwnPropertyDescriptor(ArrayBuffer.prototype, 'detached').get) should do it.

Thank you @ljharb. I updated primordials.js, would you mind checking it?

anonrig force-pushed the yagiz/use-array-buffer-transfer branch from cbe6bf7 to 646680d Compare September 8, 2024 15:20
ljharb approved these changes Sep 8, 2024
View reviewed changes

ljharb left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

jasnell added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 8, 2024

anonrig commented Sep 9, 2024

Copy link
Copy Markdown
Member Author

@jasnell it seems ci is down. 8 hours and counting for picking up this task...

aduh95 reviewed Sep 9, 2024
View reviewed changes
Comment thread lib/internal/per_context/primordials.js Outdated
aduh95 reviewed Sep 9, 2024
View reviewed changes
Comment thread lib/internal/webstreams/readablestream.js Outdated
anonrig force-pushed the yagiz/use-array-buffer-transfer branch from 646680d to ce678e1 Compare September 9, 2024 14:41
aduh95 added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Sep 9, 2024
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 9, 2024

This comment was marked as outdated.

Sign in to view

This comment was marked as outdated.

Sign in to view

nodejs-github-bot commented Sep 11, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/62307/

nodejs-github-bot commented Sep 11, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/62317/

nodejs-github-bot commented Sep 14, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/62441/

nodejs-github-bot commented Sep 15, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/62462/

anonrig added the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 16, 2024
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 16, 2024
nodejs-github-bot merged commit 9195210 into nodejs:main Sep 16, 2024

nodejs-github-bot commented Sep 16, 2024

Copy link
Copy Markdown
Collaborator

Landed in 9195210

RafaelGSS mentioned this pull request Sep 16, 2024
Merged
RafaelGSS pushed a commit that referenced this pull request Sep 16, 2024
lib,src: use built-in array buffer detach, transfer
856d59e 
PR-URL: #54837
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
RafaelGSS pushed a commit that referenced this pull request Sep 17, 2024
lib,src: use built-in array buffer detach, transfer
7415ec7 
PR-URL: #54837
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
RafaelGSS pushed a commit that referenced this pull request Sep 17, 2024
lib,src: use built-in array buffer detach, transfer
b59c8b8 
PR-URL: #54837
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

ljharb ljharb approved these changes
Qard Qard approved these changes
jasnell jasnell approved these changes
legendecas legendecas approved these changes
aduh95 aduh95 approved these changes
richardlau Awaiting requested review from richardlau

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

Back | FazBrowse Home | New Git URL