FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test: move test-fs-utimes to sequential by jasnell · Pull Request #54844 · nodejs/node · GitHub

/ node Public

test: move test-fs-utimes to sequential - #54844

Closed
jasnell wants to merge 1 commit into
nodejs:mainfrom
jasnell:move-test-fs-utimes-sequential
ConversationCommits (1)ChecksFiles changed
Closed

test: move test-fs-utimes to sequential#54844
jasnell wants to merge 1 commit into
nodejs:mainfrom
jasnell:move-test-fs-utimes-sequential

Conversation

jasnell commented Sep 8, 2024

Copy link
Copy Markdown
Member

Attempt to deal with flaky failures in CI by moving this to the sequential suite rather than the parallel suite

jasnell requested a review from anonrig September 8, 2024 00:31
nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Sep 8, 2024

This comment was marked as outdated.

Sign in to view
avivkeller added the fs Issues and PRs related to the fs subsystem / file system. label Sep 8, 2024

codecov Bot commented Sep 8, 2024 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.07%. Comparing base (123bb4c) to head (dc88b56).
Report is 212 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #54844   +/-   ##
=======================================
  Coverage   88.07%   88.07%           
=======================================
  Files         651      651           
  Lines      183396   183375   -21     
  Branches    35795    35802    +7     
=======================================
- Hits       161523   161507   -16     
+ Misses      15161    15150   -11     
- Partials     6712     6718    +6

see 45 files with indirect coverage changes

jasnell added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 8, 2024
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 8, 2024

This comment was marked as outdated.

Sign in to view

lpinca commented Sep 8, 2024

Copy link
Copy Markdown
Member

Did you get a timeout in #37692 (comment)? Because that is what was happening in our CI and only on ppc64le.

jasnell commented Sep 8, 2024

Copy link
Copy Markdown
Member Author

Did you get a timeout ...

Yes. When I ran enough concurrently load the test timed out locally. It wasn't easy but I was able to reproduce.

jasnell added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Sep 8, 2024
test: move test-fs-utimes to sequential
dc88b56 
Attempt to deal with flaky failures in CI by moving this
to the sequential suite rather than the parallel suite
jasnell force-pushed the move-test-fs-utimes-sequential branch from 21957c4 to dc88b56 Compare September 11, 2024 14:44

This comment was marked as outdated.

Sign in to view

nodejs-github-bot commented Sep 11, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/62342/

lpinca commented Sep 12, 2024 •
edited
Loading

Copy link
Copy Markdown
Member

Some tests time out due to a deadlock during process shutdown, see #52550 (comment). I think that the underlying issue is the same here. We could revert this when a fix lands.

jasnell closed this Sep 26, 2024

jasnell commented Sep 26, 2024

Copy link
Copy Markdown
Member Author

Closing this while we see if fixes to the deadlock resolve the issue

lpinca mentioned this pull request Nov 28, 2024
Merged
lpinca added a commit to lpinca/node that referenced this pull request Dec 1, 2024
test: remove test-fs-utimes flaky designation
abee765 
The issue is likely the same as other tests that time out.

Refs: nodejs#54918
Refs: nodejs#54844
Refs: nodejs#54802
nodejs-github-bot pushed a commit that referenced this pull request Dec 6, 2024
test: remove test-fs-utimes flaky designation
7904bc0 
The issue is likely the same as other tests that time out.

Refs: #54918
Refs: #54844
Refs: #54802
PR-URL: #56052
Reviewed-By: Michaël Zasso <targos@protonmail.com>
targos pushed a commit that referenced this pull request Dec 6, 2024
test: remove test-fs-utimes flaky designation
5edb8d5 
The issue is likely the same as other tests that time out.

Refs: #54918
Refs: #54844
Refs: #54802
PR-URL: #56052
Reviewed-By: Michaël Zasso <targos@protonmail.com>
aduh95 pushed a commit that referenced this pull request Dec 13, 2024
test: remove test-fs-utimes flaky designation
30ccb3f 
The issue is likely the same as other tests that time out.

Refs: #54918
Refs: #54844
Refs: #54802
PR-URL: #56052
Reviewed-By: Michaël Zasso <targos@protonmail.com>
aduh95 pushed a commit that referenced this pull request Dec 18, 2024
test: remove test-fs-utimes flaky designation
9852480 
The issue is likely the same as other tests that time out.

Refs: #54918
Refs: #54844
Refs: #54802
PR-URL: #56052
Reviewed-By: Michaël Zasso <targos@protonmail.com>
ruyadorno pushed a commit that referenced this pull request Jan 5, 2025
test: remove test-fs-utimes flaky designation
ad107ca 
The issue is likely the same as other tests that time out.

Refs: #54918
Refs: #54844
Refs: #54802
PR-URL: #56052
Reviewed-By: Michaël Zasso <targos@protonmail.com>
marco-ippolito pushed a commit that referenced this pull request Jan 22, 2025
test: remove test-fs-utimes flaky designation
d803f2d 
The issue is likely the same as other tests that time out.

Refs: #54918
Refs: #54844
Refs: #54802
PR-URL: #56052
Reviewed-By: Michaël Zasso <targos@protonmail.com>
marco-ippolito pushed a commit that referenced this pull request Jan 24, 2025
test: remove test-fs-utimes flaky designation
21e21a2 
The issue is likely the same as other tests that time out.

Refs: #54918
Refs: #54844
Refs: #54802
PR-URL: #56052
Reviewed-By: Michaël Zasso <targos@protonmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

anonrig anonrig approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. fs Issues and PRs related to the fs subsystem / file system. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL