FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test: fix invalid test by avivkeller · Pull Request #54935 · nodejs/node · GitHub

/ node Public

test: fix invalid test - #54935

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
avivkeller:patch-504488
Sep 20, 2024
ConversationCommits (1)ChecksFiles changed
Merged

test: fix invalid test#54935
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
avivkeller:patch-504488

Conversation

avivkeller commented Sep 14, 2024 •
edited
Loading

Copy link
Copy Markdown
Member

The test setup is incorrect:

it('should error on import', async () => {
  try {
    await import(fixtures.fileURL('es-modules/noext-wasm'));
    mustNotCall();
  } catch (err) {
    ok(err instanceof SyntaxError);
  }
});

In the correct setup, mustNotCall() should be invoked as mustNotCall()();. However, the test fails in this case, indicating that the import is actually successful. This PR fixes the invalid test.

nodejs-github-bot added esm Issues and PRs related to the ECMAScript Modules implementation. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Sep 14, 2024
avivkeller added loaders Issues and PRs related to ES module loaders esm Issues and PRs related to the ECMAScript Modules implementation. needs-ci PRs that need a full CI run. and removed esm Issues and PRs related to the ECMAScript Modules implementation. needs-ci PRs that need a full CI run. labels Sep 14, 2024
avivkeller changed the title test: remove invalid test test: fix invalid test Sep 14, 2024

codecov Bot commented Sep 14, 2024 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.07%. Comparing base (75e4d0d) to head (b5aa5a6).
Report is 540 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #54935   +/-   ##
=======================================
  Coverage   88.06%   88.07%           
=======================================
  Files         651      651           
  Lines      183451   183451           
  Branches    35821    35827    +6     
=======================================
+ Hits       161564   161574   +10     
+ Misses      15133    15130    -3     
+ Partials     6754     6747    -7

see 23 files with indirect coverage changes

lpinca added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 17, 2024
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 17, 2024

nodejs-github-bot commented Sep 17, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/62495/

nodejs-github-bot commented Sep 18, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/62527/

avivkeller added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Sep 18, 2024
lpinca added the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 20, 2024
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 20, 2024
nodejs-github-bot merged commit 2a1607c into nodejs:main Sep 20, 2024

nodejs-github-bot commented Sep 20, 2024

Copy link
Copy Markdown
Collaborator

Landed in 2a1607c

targos pushed a commit that referenced this pull request Oct 4, 2024
test: fix invalid wasm test
327a8f7 
PR-URL: #54935
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
aduh95 mentioned this pull request Oct 9, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

benjamingr benjamingr approved these changes
lpinca lpinca approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. esm Issues and PRs related to the ECMAScript Modules implementation. loaders Issues and PRs related to ES module loaders needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL