os: use const with early return for path - #54959
Merged
nodejs-github-bot merged 1 commit intoSep 18, 2024
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Codecov ReportAll modified and coverable lines are covered by tests ✅ Additional details and impacted files @@ Coverage Diff @@
## main #54959 +/- ##
==========================================
- Coverage 88.07% 88.06% -0.01%
==========================================
Files 652 652
Lines 183542 183543 +1
Branches 35862 35858 -4
==========================================
- Hits 161653 161639 -14
- Misses 15144 15154 +10
- Partials 6745 6750 +5
|
Sorry, something went wrong.
This comment was marked as outdated.
lpinca
approved these changes
Sep 16, 2024
jakecastelli
approved these changes
Sep 16, 2024
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
atlowChemi
approved these changes
Sep 16, 2024
anonrig
approved these changes
Sep 17, 2024
Copy link
Copy Markdown
Member
|
You beat me to it. Thank you! |
Sorry, something went wrong.
targos
pushed a commit
that referenced
this pull request
Oct 4, 2024
PR-URL: #54959 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com> Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
Assignees
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs: #54709 (comment)