FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

lib, tools: remove duplicate requires by avivkeller · Pull Request #54987 · nodejs/node · GitHub

/ node Public

lib, tools: remove duplicate requires - #54987

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
avivkeller:remove-duplicate-requires
Sep 25, 2024
ConversationCommits (1)ChecksFiles changed
Merged

lib, tools: remove duplicate requires#54987
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
avivkeller:remove-duplicate-requires

Conversation

avivkeller commented Sep 17, 2024 •
edited
Loading

Copy link
Copy Markdown
Member

Updates the eslint rule to check if a require in a function is already defined at the top-level.

nodejs-github-bot commented Sep 17, 2024

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/loaders
  • @nodejs/startup

nodejs-github-bot added lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Sep 17, 2024
avivkeller added the tools Issues and PRs related to the tools directory. label Sep 17, 2024
avivkeller commented Sep 17, 2024
View reviewed changes
Comment thread lib/internal/modules/run_main.js Outdated

codecov Bot commented Sep 17, 2024 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.24%. Comparing base (76edde5) to head (a572215).
Report is 404 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #54987      +/-   ##
==========================================
- Coverage   88.26%   88.24%   -0.02%     
==========================================
  Files         651      651              
  Lines      183894   183873      -21     
  Branches    35858    35851       -7     
==========================================
- Hits       162315   162266      -49     
- Misses      14882    14894      +12     
- Partials     6697     6713      +16
Files with missing lines Coverage Δ
lib/events.js 99.83% <100.00%> (-0.01%) ⬇️
lib/internal/abort_controller.js 98.00% <100.00%> (-0.03%) ⬇️
...ernal/bootstrap/switches/does_own_process_state.js 96.52% <100.00%> (+0.63%) ⬆️
lib/internal/main/worker_thread.js 95.47% <100.00%> (ø)
lib/internal/modules/cjs/loader.js 97.36% <100.00%> (-0.01%) ⬇️
lib/internal/modules/esm/loader.js 98.34% <100.00%> (+<0.01%) ⬆️
lib/internal/modules/esm/resolve.js 96.62% <ø> (-0.01%) ⬇️
lib/internal/process/pre_execution.js 93.38% <100.00%> (-0.44%) ⬇️
lib/internal/process/warning.js 99.04% <100.00%> (+1.35%) ⬆️

... and 27 files with indirect coverage changes

avivkeller mentioned this pull request Sep 21, 2024
Merged
avivkeller added the blocked PRs that are blocked by other issues or PRs. label Sep 21, 2024
avivkeller added request-ci Add this label to start a Jenkins CI on a PR. and removed blocked PRs that are blocked by other issues or PRs. labels Sep 23, 2024

avivkeller commented Sep 23, 2024

Copy link
Copy Markdown
Member Author

No longer blocked.

avivkeller added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Sep 23, 2024
github-actions Bot added request-ci-failed An error occurred while starting CI via request-ci label, and manual interventon is needed. and removed request-ci Add this label to start a Jenkins CI on a PR. labels Sep 23, 2024

github-actions Bot commented Sep 23, 2024

Copy link
Copy Markdown
Contributor
Failed to start CI
   ⚠  Something was pushed to the Pull Request branch since the last approving review.
   ✘  Refusing to run CI on potentially unsafe PR
https://github.com/nodejs/node/actions/runs/11001927470

aduh95 added request-ci Add this label to start a Jenkins CI on a PR. and removed request-ci-failed An error occurred while starting CI via request-ci label, and manual interventon is needed. labels Sep 23, 2024
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 23, 2024

nodejs-github-bot commented Sep 23, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/62704/

avivkeller commented Sep 24, 2024

Copy link
Copy Markdown
Member Author

CI is 🟢 / 🟠 (2 + 1 Flakes)

nodejs-github-bot commented Sep 24, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/62751/

avivkeller commented Sep 25, 2024

Copy link
Copy Markdown
Member Author

CI is 🟢 🎉

aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 25, 2024
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 25, 2024
nodejs-github-bot merged commit 5c22d19 into nodejs:main Sep 25, 2024

nodejs-github-bot commented Sep 25, 2024

Copy link
Copy Markdown
Collaborator

Landed in 5c22d19

targos pushed a commit that referenced this pull request Oct 4, 2024
lib, tools: remove duplicate requires
566179c 
PR-URL: #54987
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
aduh95 mentioned this pull request Oct 9, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jasnell jasnell approved these changes
aduh95 aduh95 approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL